vignesh/dolibarr
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
dolibarr/test/phpunit/FileUploadTest.php

517 lines
17 KiB
PHP
Raw Normal View History

NEW Drag and drop a file on the 23 remaining cards (#39473) * FIX Drag and drop of a file reports a wrong error, or none at all The error handler of dragAndDropFileUpload() had three defects that all end on the user believing the file was attached when it was not. - The first assignment of the message was dead code, there was no return after the test on the http code 403, so a refusal was reported as a generic error. - The key ErrorUploadPermissionDenied it used exists in no language file, so the raw key was shown. - JSON.parse() was called with no try/catch on an answer that is not always a json, a fatal error of the endpoint or a request over post_max_size for example. The exception left the user on a page with no message at all. - An empty list of files was treated as a success, while it means the endpoint stored nothing. The value of PHP_SELF is also escaped before it is written into the 6 generated javascript strings. It holds the path info of the request on a server that accepts it, so it is a user input. dol_escape_js() is called with the mode that escapes a double quote by a double quote, the strings being delimited by double quotes, and the sequence '</' is escaped too because the function does not do it and the path info could otherwise close the script tag and open one of its own. Adds the key ErrorOnAtLeastOneFileUpload to en_US, used when some files of a batch failed and some did not. * FIX getMultidirOutput returns a directory the Documents tab does not read Four defects of the same function, all ending on a file stored where the user will never see it, or written outside the documents directory. - The ref of the project of a task was only passed through dol_sanitizePathName(), which keeps a slash, a colon and the accented chars, while projet/tasks/document.php sanitizes it with dol_sanitizeFileName(). A project ref holding a slash even created an extra level of directory. Measured on real databases: 304 projects over 330 hold a slash on one of them, carrying 701 tasks over 824. - The same case calls $object->fetchProject() with no guard, while the signature of the function accepts an object that is not a CommonObject, and even a null when a module is given. Such a caller gets a fatal error where it expects the error string. No core caller is in that case today, an external module or a hook can be. - The entity of the object may have no declared directory, an object shared by another entity for example. The undefined index returned a relative path, so the caller read or wrote under the web root. The current entity is used instead, and the fallback is logged because the directory is then not the one of the entity of the object, which matters for a caller that deletes files. - When the current entity has no declared directory either, the fallback returned the sub directory alone, again a relative path. The same error than for a module that declares no directory at all is now returned. Adds the sub directory of a partnership and of a stock transfer, which their own document tabs already read. * FIX getElementProperties answers wrong properties for 9 elements A customer payment, a supplier payment, a various payment, a stock transfer and the 4 objects of the hrm module had no properties at all, or wrong ones, so any caller that resolves a class, a table or a document directory from an element failed on them. - payment, payment_supplier and payment_various had no branch. The branch of a customer payment tests $elementType and not $element, because the rule on the elements named myobject_mysubobject rewrites $element to 'payment' for 'payment_salary' too, which is stored somewhere else. - job, position, skill and evaluation answered a wrong table (hrm_job_user for a position, and so on) and no sub directory, while their document tabs read one named after the element. - stocktransfer answered an empty classname, because it is not the ucfirst() of the element, so a caller doing new $classname($db) ended on a fatal error. - The sub directory was concatenated even when the module is disabled and the directory is empty, which answered a path at the root of the file system. - A contact and a conference are stored into a sub directory their tab reads. isModEnabled('invoice') is tested for a customer payment: there is no module named 'compta', so testing it was always false, while $conf->compta->payment is set unconditionally by Conf::setValues() and could not be used as a proxy. * FIX Access refused to everyone on 11 objects of the core restrictedArea() and checkUserAccessToObject() refuse the access to objects that no permission and no rule can match, whatever the user, an administrator included. - The hrm module declares no permission at its first level, only 'all', and the stocktransfer module only 'stocktransfer'. A check on the module itself therefore tests a permission that does not exist. The mapping is the same one as into User::hasRight(). - The module of an event organization declares no permission at all, its whole permission block being commented out on purpose, and its cards check the parent project instead. The feature is mapped onto that project, with the two guards the card has: an external user is refused, and so is a conference with no parent project, whose id of 0 would otherwise grant an access with no check on the record at all. - The default rule of checkUserAccessToObject() builds its sql on the columns entity and fk_soc of the table. llx_asset, llx_paiement, llx_paiementfourn and llx_workstation_workstation have no fk_soc, and llx_hrm_job, llx_hrm_job_user and llx_hrm_skill have neither. The sql failed, so the access was refused to every user this rule applies to. These tables are now checked on their entity only, which is what the $check rule already does for the same class of tables, and the 3 tables of hrm can be checked on nothing at all. The rule is selected on the table and not on the element, because $object is an id and not an object for most of the callers, the cards of an asset and of a workstation included, which are broken today for any user without the permission to see all third parties. - An external user is refused explicitly on those tables: none of these objects is linked to a third party, so the default rule refused him through a link that does not exist, and the rules that replace it do not look at the third party of the user at all. Measured on a vanilla instance with 5 profiles, an administrator, an internal user with every right, one without the permission to see all third parties, one that is not a sales representative of the third party of the object, and an external user: the 11 objects go from refused to granted for the internal users and stay refused for the external one, and the 26 other elements answer exactly the same for the 5 profiles. * FIX A file dropped on a card is lost, or reported as refused when it was stored FileUpload stores the file into a directory that the "Attached files" tab of the object never reads, so the user attaches a file that no screen will ever show, and nothing is indexed in database to find it back. Measured on real databases: 216487 thirdparties over 216887 and 157852 products over 280319 are in that case on the cards that already enable the drag and drop. - The directory of the object is now forged with get_exdir(), the way the tabs do: it always uses the id for a thirdparty, whose ref is a company name and is not unique, and it falls back on the id when the ref is empty. The sub directory of the module is read with getMultidirOutput(), which knows the elements that store their documents into one. That function does not return an empty string when it fails but a string starting with 'error-', so only an absolute path is accepted: writing into that string would create the files under the web root. - fetchObjectByElement() returns an object even when fetch() returned 0. The object was then not loaded, and the file was stored at the root of the directory of the module, out of any object. The constructor now throws, and the endpoint answers the error with the same json contract than a successful call so that the caller can show it, instead of a fatal error and an http 500. - An attachment of the same name was silently overwritten, dol_move_uploaded_file() being called with $allowoverwrite = 1 while the name was checked before the ref of the object was added as a prefix. The check is done again on the final name, and on the .noexe suffixed name too, which that function appends to an executable file. - An executable file was renamed with that .noexe suffix and then reported as an error, while it was correctly stored. - The endpoint called restrictedArea() with an empty feature when the element is unknown, and the loop of that function then takes no branch at all and grants the access with no check. It refuses before, with the same http code and the same message than a refusal, so that a user cannot tell an object that exists but is not allowed from an object that does not exist. The refusal of an external user on an object of another third party answered a message of its own, which allowed the same enumeration. Comes with the tests of the path resolution, of the fallback of get_exdir(), of the rejection of the error string of getMultidirOutput(), and of the file name deduplication. * FIX Remove the drop area from 13 cards where dropping a file is harmful Two distinct groups, both of them removing a drop area that only produces a result the user does not want. 7 pages have no "Attached files" tab at all, so a file dropped on them can be reached by no screen: a fiscal year and its info page, an accounting model, a webhook trigger history, an intracomm report, a bookcal calendar and its booking list. Measured: 4 of them accepted the upload and wrote an orphan file, the accounting model wrote it at the root of the directory of the module, out of any object, and the 2 bookcal ones answered an http 500. 6 cards print their tabs inside their edit form, so the drop area covered that form: a product, an expense report, a VAT payment, a social contribution, a loan and a salary. Dropping a file there reloads the page, which discards what the user is typing. A product and an expense report have a second call for the read only view, so the drop area is only removed from the call of the edit branch; the 4 others share a single call between both views, so the parameter is now conditional. * NEW Drag and drop a file on the 23 remaining cards Every card of the core that owns an "Attached files" tab can now receive a file by drag and drop, which was the case of 32 of them only. The 23 added here are an asset, an event, a various payment, a customer payment, a contact, a donation, a conference or booth, a shipment, a supplier payment, a leave request, an evaluation, a job, a position, a skill, a knowledge record, a manufacturing order, a partnership, a lot, a stock transfer, a task, a reception, a resource and a workstation. The tab bar of a leave request and of a resource is printed inside their edit form, so the drop area is not enabled there: dropping a file reloads the page, which would discard what the user is typing. The card of a supplier payment prints its tab bar even when the object was not loaded, so the drop area is only enabled when it is. * FIX getMultidirOutput refuses an entity with no directory instead of falling back [skip-claudemd] The previous revision of this PR fell back on the directory of the current entity when the entity of the object had none, with a LOG_WARNING. On a multicompany install that made a caller read, write and above all delete files in the directory of another entity. Refuse instead: the function already answers 'error-diroutput-not-defined-for-this-object' when the module declares no directory at all, so the caller has one behaviour to handle, not two. The entity is cast to int, which is what the array index needs and what silences the four PhanTypeMismatchDimFetchNullable this function reported. --------- Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2026-08-19 00:46:21 +00:00
<?php
/* Copyright (C) 2026 ATM Consulting
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 3 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <https://www.gnu.org/licenses/>.
* or see https://www.gnu.org/
*/
/**
* \file test/phpunit/FileUploadTest.php
* \ingroup test
* \brief PHPUnit test of the class FileUpload, used by the drag and drop of a file on a card.
* \remarks To run this script as CLI: phpunit FileUploadTest.php < /dev/null
* The redirection of stdin is only needed on an interactive terminal, because the tested
* code reads php://input when the file is not a real http upload.
*/
global $conf,$user,$langs,$db;
require_once dirname(__FILE__).'/../../htdocs/master.inc.php';
require_once dirname(__FILE__).'/../../htdocs/core/class/fileupload.class.php';
require_once dirname(__FILE__).'/../../htdocs/core/lib/files.lib.php';
require_once dirname(__FILE__).'/../../htdocs/product/class/product.class.php';
require_once dirname(__FILE__).'/../../htdocs/societe/class/societe.class.php';
require_once dirname(__FILE__).'/../../htdocs/contact/class/contact.class.php';
require_once dirname(__FILE__).'/../../htdocs/projet/class/project.class.php';
require_once dirname(__FILE__).'/../../htdocs/projet/class/task.class.php';
require_once dirname(__FILE__).'/CommonClassTest.class.php';
if (!defined('NOREQUIREUSER')) {
define('NOREQUIREUSER', '1');
}
if (!defined('NOREQUIREDB')) {
define('NOREQUIREDB', '1');
}
if (!defined('NOREQUIRESOC')) {
define('NOREQUIRESOC', '1');
}
if (!defined('NOREQUIRETRAN')) {
define('NOREQUIRETRAN', '1');
}
if (!defined('NOCSRFCHECK')) {
define('NOCSRFCHECK', '1');
}
if (!defined('NOTOKENRENEWAL')) {
define('NOTOKENRENEWAL', '1');
}
if (!defined('NOREQUIREMENU')) {
define('NOREQUIREMENU', '1');
}
if (!defined('NOREQUIREHTML')) {
define('NOREQUIREHTML', '1');
}
if (!defined('NOREQUIREAJAX')) {
define('NOREQUIREAJAX', '1');
}
if (!defined("NOLOGIN")) {
define("NOLOGIN", '1');
}
/**
* Class for PHPUnit tests of FileUpload
*
* @backupGlobals disabled
* @backupStaticAttributes enabled
* @remarks backupGlobals must be disabled to have db,conf,user and lang not erased.
*/
class FileUploadTest extends CommonClassTest
{
/**
* Directories created by the tests, removed at the end
* @var string[]
*/
protected static $dirstoclean = array();
/**
* Temporary files created by the tests, removed at the end
* @var string[]
*/
protected static $filestoclean = array();
/**
* Objects of the fixture, removed by the rollback of the transaction
* @var array<string,CommonObject>
*/
protected static $objects = array();
/**
* setUpBeforeClass
*
* @return void
*/
public static function setUpBeforeClass(): void
{
global $conf, $db, $user;
parent::setUpBeforeClass();
$conf->global->MAIN_DISABLE_SUGGEST_REF_AS_PREFIX = 0;
// A thirdparty
$thirdparty = new Societe($db);
$thirdparty->initAsSpecimen();
$thirdparty->name = 'Test FileUpload';
$thirdparty->country_id = 1;
$id = $thirdparty->create($user);
if ($id <= 0) {
die("Failed to create the thirdparty: ".$thirdparty->errorsToString()."\n");
}
$thirdparty->fetch($id);
self::$objects['societe'] = $thirdparty;
// A contact of this thirdparty
$contact = new Contact($db);
$contact->lastname = 'Doe';
$contact->firstname = 'John';
$contact->socid = $thirdparty->id;
$contact->country_id = 1;
$id = $contact->create($user);
if ($id <= 0) {
die("Failed to create the contact: ".$contact->errorsToString()."\n");
}
$contact->fetch($id);
self::$objects['contact'] = $contact;
// A product
$product = new Product($db);
$product->ref = 'PRODUCT-FILEUPLOAD-TEST';
$product->label = 'Test FileUpload';
$product->type = Product::TYPE_PRODUCT;
$id = $product->create($user);
if ($id <= 0) {
die("Failed to create the product: ".$product->errorsToString()."\n");
}
$product->fetch($id);
self::$objects['product'] = $product;
// A project whose ref holds the chars a path must not keep, and a task of this project
$project = new Project($db);
$project->ref = 'PJ/UP:é 2026';
$project->title = 'Test FileUpload';
$project->socid = $thirdparty->id;
$id = $project->create($user);
if ($id <= 0) {
die("Failed to create the project: ".$project->errorsToString()."\n");
}
$project->fetch($id);
self::$objects['project'] = $project;
$task = new Task($db);
$task->ref = 'TASK-FILEUPLOAD-TEST';
$task->label = 'Test FileUpload';
$task->fk_project = $project->id;
$id = $task->create($user);
if ($id <= 0) {
die("Failed to create the task: ".$task->errorsToString()."\n");
}
$task->fetch($id);
self::$objects['project_task'] = $task;
}
/**
* tearDownAfterClass
*
* @return void
*/
public static function tearDownAfterClass(): void
{
foreach (self::$dirstoclean as $dir) {
if (is_dir($dir)) {
dol_delete_dir_recursive($dir);
}
}
foreach (self::$filestoclean as $file) {
@unlink($file);
}
// The objects created by setUpBeforeClass() are removed by the rollback of the parent, which
// closes the transaction opened by its own setUpBeforeClass().
parent::tearDownAfterClass();
}
/**
* Build a FileUpload for an object and return its upload directory.
*
* @param string $element Element code
* @param int $id Id of the object
* @return string Upload directory
*/
protected function uploadDirOf($element, $id)
{
$upload = new FileUpload(null, $id, $element);
$this->assertIsArray($upload->options);
$this->assertArrayHasKey('upload_dir', $upload->options);
return $upload->options['upload_dir'];
}
//
// Resolution of the directory where the file is stored
//
/**
* The directory of a product must be the one read by product/document.php, otherwise the file is
* stored but never shown into the "Attached files" tab.
*
* @return void
*/
public function testUploadDirOfAProduct()
{
global $conf;
$object = self::$objects['product'];
// The formula of product/document.php, written here on purpose so the test does not use the
// code it checks to build its expectation.
$expected = $conf->product->multidir_output[$object->entity].'/'.dol_sanitizeFileName($object->ref).'/';
$this->assertSame($expected, $this->uploadDirOf('product', $object->id));
}
/**
* A thirdparty stores its documents into a directory named after its id, not its ref.
*
* @return void
*/
public function testUploadDirOfAThirdpartyUsesTheId()
{
global $conf;
$object = self::$objects['societe'];
// The formula of societe/document.php
$expected = $conf->societe->multidir_output[$object->entity].'/'.$object->id.'/';
$this->assertSame($expected, $this->uploadDirOf('societe', $object->id));
$this->assertStringNotContainsString(dol_sanitizeFileName($object->name), $this->uploadDirOf('societe', $object->id), 'The name of a thirdparty must never appear into its directory');
}
/**
* A contact is stored into a sub directory of the thirdparty module. getMultidirOutput() does not know
* this element and answers its sentinel, so this asserts the fallback on getElementProperties().
*
* @return void
*/
public function testUploadDirOfAContactFallsBackOnGetElementProperties()
{
global $conf;
$object = self::$objects['contact'];
$this->assertStringStartsWith('error-diroutput-not-defined-for-this-object=', (string) getMultidirOutput($object, 'contact'), 'The fixture requires getMultidirOutput to fail on a contact');
// The formula of contact/document.php
$expected = $conf->societe->multidir_output[$object->entity].'/contact/'.dol_sanitizeFileName($object->ref).'/';
$this->assertSame($expected, $this->uploadDirOf('contact', $object->id));
}
/**
* A task is stored into a sub directory named after the ref of its project. That ref is a user input,
* so it must be sanitized the same way projet/tasks/document.php does it.
*
* @return void
*/
public function testUploadDirOfATaskSanitizesTheProjectRef()
{
global $conf;
$task = self::$objects['project_task'];
$project = self::$objects['project'];
$this->assertStringContainsString('/', $project->ref, 'The fixture requires a project ref holding a slash');
// The formula of projet/tasks/document.php
$expected = $conf->project->multidir_output[$project->entity].'/'.dol_sanitizeFileName($project->ref).'/'.dol_sanitizeFileName($task->ref).'/';
$dir = $this->uploadDirOf('project_task', $task->id);
$this->assertSame($expected, $dir);
$this->assertStringNotContainsString('PJ/UP', $dir, 'The slash of the project ref must not create a sub directory');
$this->assertStringNotContainsString(':', $dir, 'A colon of the project ref must not be kept');
}
/**
* Whatever the element, the directory is absolute, inside DOL_DATA_ROOT, and never holds the sentinel
* string returned by getMultidirOutput() when it fails.
*
* @return void
*/
public function testUploadDirIsNeverTheSentinelOfGetMultidirOutput()
{
foreach (array('product', 'societe', 'contact', 'project_task') as $element) {
$dir = $this->uploadDirOf($element, self::$objects[$element]->id);
$this->assertStringNotContainsString('error-diroutput-not-defined-for-this-object', $dir, 'The sentinel leaked into the directory of the element '.$element);
$this->assertStringStartsWith(DOL_DATA_ROOT, $dir, 'The directory of the element '.$element.' must be inside DOL_DATA_ROOT');
$this->assertStringNotContainsString('//', $dir, 'The directory of the element '.$element.' must not hold a double slash');
$this->assertStringEndsWith('/', $dir, 'The directory must end with a slash, the file name is concatenated to it');
}
}
/**
* The file name is prefixed by the ref of the object, and that ref is sanitized because it is a user
* input that may hold a slash.
*
* @return void
*/
public function testSavingDocMaskIsSanitized()
{
$project = self::$objects['project'];
$upload = new FileUpload(null, $project->id, 'project');
$this->assertSame(dol_sanitizeFileName($project->ref).'-__file__', $upload->options['saving_doc_mask']);
$this->assertStringNotContainsString('/', $upload->options['saving_doc_mask'], 'A file name mask must never hold a slash');
}
//
// Refusals
//
/**
* An object that does not exist must be refused, otherwise the file is stored at the root of the
* directory of the module, out of any object and out of any permission check.
*
* @return void
*/
public function testConstructRefusesAnObjectThatDoesNotExist()
{
$this->expectException(Exception::class);
$this->expectExceptionMessage('objectnotfound');
new FileUpload(null, 99999999, 'product');
}
/**
* An id of 0 must be refused too, it would answer the directory of every unsaved object.
*
* @return void
*/
public function testConstructRefusesAnEmptyId()
{
$this->expectException(Exception::class);
$this->expectExceptionMessage('objectnotfound');
new FileUpload(null, 0, 'product');
}
/**
* An element with no directory at all must be refused instead of writing anywhere.
*
* @return void
*/
public function testConstructRefusesAnUnknownElement()
{
$this->expectException(Exception::class);
new FileUpload(null, 1, 'anelementthatdoesnotexist');
}
//
// Deduplication of the name of the uploaded file
//
/**
* Build a FileUpload for an object of the fixture and empty its upload directory, so the tests below
* start from a known set of already used names.
*
* @param string $element Element code of the fixture
* @return FileUpload Instance ready to use
*/
protected function prepareUploadDir($element)
{
$object = self::$objects[$element];
$upload = new FileUpload(null, $object->id, $element);
$dir = $upload->options['upload_dir'];
if (is_dir($dir)) {
dol_delete_dir_recursive($dir);
}
dol_mkdir($dir);
self::$dirstoclean[$dir] = $dir;
return $upload;
}
/**
* Create the temporary file playing the role of the file uploaded by the browser.
*
* @return string Path of the file
*/
protected function makeTmpFile()
{
$tmpfile = DOL_DATA_ROOT.'/admin/temp/fileuploadtest-'.getmypid().'.txt';
dol_mkdir(dirname($tmpfile));
file_put_contents($tmpfile, 'content');
self::$filestoclean[$tmpfile] = $tmpfile;
return $tmpfile;
}
/**
* Call the protected handleFileUpload() of FileUpload.
*
* @param FileUpload $upload Instance
* @param string $tmpfile Path of the file to upload
* @param string $name Name sent by the browser
* @return stdClass The file object answered by handleFileUpload()
*/
protected function callHandleFileUpload($upload, $tmpfile, $name)
{
$method = new ReflectionMethod('FileUpload', 'handleFileUpload');
$method->setAccessible(true);
// validate() reads CONTENT_LENGTH when the file is not a real http upload
$_SERVER['CONTENT_LENGTH'] = 10;
return $method->invoke($upload, $tmpfile, $name, 0, 'text/plain', 0, 0);
}
/**
* A name that is free must be kept as it is, only prefixed by the ref of the object.
*
* @return void
*/
public function testUploadOfAFreeNameIsKept()
{
$upload = $this->prepareUploadDir('product');
$prefix = dol_sanitizeFileName(self::$objects['product']->ref).'-';
$file = $this->callHandleFileUpload($upload, $this->makeTmpFile(), 'afreename.txt');
$this->assertSame($prefix.'afreename.txt', $file->name, 'A free name must be kept, only the prefix of the ref is added');
}
/**
* Uploading twice the same file must not overwrite the first one: dol_move_uploaded_file() is called
* with $allowoverwrite = 1, so the name must be made unique before.
* trimFileName() already does that check, but on the name before the prefix of the ref is added, so
* it compares a name that is not the one stored.
*
* @return void
*/
public function testUploadOfAnAlreadyExistingNameIsRenamed()
{
$upload = $this->prepareUploadDir('product');
$dir = $upload->options['upload_dir'];
$prefix = dol_sanitizeFileName(self::$objects['product']->ref).'-';
// The name is already used, with the prefix that trimFileName() does not know about
file_put_contents($dir.$prefix.'mydoc.txt', 'first');
$file = $this->callHandleFileUpload($upload, $this->makeTmpFile(), 'mydoc.txt');
$this->assertSame($prefix.'mydoc (1).txt', $file->name, 'The name must be made unique, the first file must not be overwritten');
$this->assertSame('first', file_get_contents($dir.$prefix.'mydoc.txt'), 'The first file must be untouched');
$this->assertFileExists($dir.$file->name, 'The new file must be stored under its new name');
}
/**
* The renaming must be repeated as long as the name is used, so a third upload gets a third name.
*
* @return void
*/
public function testUploadOfAnAlreadyExistingNameIsRenamedAgain()
{
$upload = $this->prepareUploadDir('product');
$dir = $upload->options['upload_dir'];
$prefix = dol_sanitizeFileName(self::$objects['product']->ref).'-';
file_put_contents($dir.$prefix.'mydoc.txt', 'first');
file_put_contents($dir.$prefix.'mydoc (1).txt', 'second');
$file = $this->callHandleFileUpload($upload, $this->makeTmpFile(), 'mydoc.txt');
$this->assertSame($prefix.'mydoc (2).txt', $file->name);
$this->assertSame('first', file_get_contents($dir.$prefix.'mydoc.txt'));
$this->assertSame('second', file_get_contents($dir.$prefix.'mydoc (1).txt'));
}
/**
* A file whose name is executable is stored by dol_move_uploaded_file() with a '.noexe' suffix added.
* The check on an already used name must look for that suffixed name too, otherwise such a file is
* silently overwritten at each upload.
*
* @return void
*/
public function testUploadOfAnAlreadyExistingNoexeNameIsRenamed()
{
$upload = $this->prepareUploadDir('product');
$dir = $upload->options['upload_dir'];
$prefix = dol_sanitizeFileName(self::$objects['product']->ref).'-';
// A previous upload of the same file was renamed with the .noexe suffix
file_put_contents($dir.$prefix.'myscript.php.noexe', 'first');
$file = $this->callHandleFileUpload($upload, $this->makeTmpFile(), 'myscript.php');
$this->assertStringStartsWith($prefix.'myscript (1).php', $file->name, 'A name already used with the .noexe suffix must be made unique too');
$this->assertSame('first', file_get_contents($dir.$prefix.'myscript.php.noexe'), 'The first file must be untouched');
}
}
Reference in a new issue Copy permalink