Qual: Upgrade php version to run phan, add ast (#38143)

* Qual: Upgrade php version to run phan, add ast

* Qual: Fix PhanPluginUnknownClosureReturnType

* Fix: Correct shebang

* Qual: Ignore deprecated xml_set_object notice

.github/scripts/get_changed_php.sh

@@ -1,4 +1,4 @@
-b!/bin/bash
+#!/bin/bash
 # Copyright (C) 2025		MDW	<mdeweerd@users.noreply.github.com>
 
 set -euo pipefail

.github/workflows/phan.yml

@@ -47,8 +47,9 @@ jobs:
       - name: Setup PHP
         uses: shivammathur/setup-php@v2
         with:
-          php-version: 8.2
+          php-version: 8.4
           coverage: none # disable xdebug, pcov
+          extensions: ast
           tools: cs2pr:1.8.6,phan:5.5.2
 
 

htdocs/accountancy/class/lettering.class.php

@@ -3,7 +3,7 @@
  * Copyright (C) 2013       Olivier Geffroy         <jeff@jeffinfo.com>
  * Copyright (C) 2013-2026  Alexandre Spangaro      <alexandre@inovea-conseil.com>
  * Copyright (C) 2018-2026  Frédéric France         <frederic.france@free.fr>
- * Copyright (C) 2024-2025	MDW						<mdeweerd@users.noreply.github.com>
+ * Copyright (C) 2024-2026	MDW						<mdeweerd@users.noreply.github.com>
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -593,7 +593,10 @@ class Lettering extends BookKeeping
 		// Cross-fiscal-year matching is forbidden
 		if (count($fiscalYearRows) > 1) {
 			$periods = array_map(
-				/** @param object $row */
+				/**
+				 * @param object $row
+				 * @return string
+				 */
 				function ($row) {
 					return dol_print_date($this->db->jdate($row->date_start), 'day') . ' – ' . dol_print_date($this->db->jdate($row->date_end), 'day');
 				},

htdocs/core/class/rssparser.class.php

@@ -367,6 +367,7 @@ class RssParser
 						return -1;
 					}
 
+					// @phan-suppress-next-line PhanDeprecatedFunctionInternal
 					xml_set_object($xmlparser, $this);
 					// @phan-suppress-next-line PhanUndeclaredFunctionInCallable
 					xml_set_element_handler($xmlparser, 'feed_start_element', 'feed_end_element'); // @phpstan-ignore-line