2026-01-18 18:56:51 +00:00
|
|
|
<?php
|
|
|
|
|
|
refactor: settings redesign, Spanish translations, language system, strict_types
Settings pages:
- Redesign layout to match Sendkit (max-w-4xl, space-y-12, Separator sections)
- Merge Members page into Workspace settings with Table, invite Dialog, ConfirmDeleteModal
- Add workspace logo upload/delete routes and controller methods
- Translate all hardcoded strings in Workspace.vue modals
Language system:
- Drop languages table, replace language_id FK with locale string column on users
- Create config/languages.php for available languages and default locale
- Add Spanish (es) translations (13 files)
- Simplify HandleInertiaRequests, ProfileController, RegisteredUserController
Code quality:
- Add declare(strict_types=1) to all PHP files
- Fix MastodonPublisher using wrong attribute (filename -> original_filename)
- Fix HasMediaTest for new has_photo/photo_url accessors
- Fix PublishToSocialPlatformTest type error revealed by strict_types
- Remove orphaned Language model from AppServiceProvider morph map
- Update User TypeScript interface (has_photo, photo_url, locale)
- Eager load media relation on workspaces to prevent N+1
- Add 8 new tests for workspace logo upload/delete
- Update workspace settings test to assert members/invitations props
All 710 tests passing.
2026-03-30 03:20:43 +00:00
|
|
|
declare(strict_types=1);
|
|
|
|
|
|
2026-01-18 18:56:51 +00:00
|
|
|
use App\Enums\SocialAccount\Platform;
|
|
|
|
|
use App\Enums\SocialAccount\Status;
|
|
|
|
|
use App\Models\SocialAccount;
|
|
|
|
|
use App\Models\User;
|
|
|
|
|
use App\Models\Workspace;
|
|
|
|
|
use Illuminate\Support\Facades\Http;
|
|
|
|
|
use Laravel\Socialite\Facades\Socialite;
|
|
|
|
|
use Laravel\Socialite\Two\User as SocialiteUser;
|
|
|
|
|
|
|
|
|
|
beforeEach(function () {
|
|
|
|
|
$this->user = User::factory()->create();
|
|
|
|
|
$this->workspace = Workspace::factory()->create(['user_id' => $this->user->id]);
|
|
|
|
|
$this->user->update(['current_workspace_id' => $this->workspace->id]);
|
|
|
|
|
$this->workspace->members()->attach($this->user->id, ['role' => 'owner']);
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
test('linkedin connect redirects to oauth provider', function () {
|
|
|
|
|
Socialite::shouldReceive('driver')
|
|
|
|
|
->with('linkedin')
|
|
|
|
|
->andReturn(Mockery::mock([
|
|
|
|
|
'scopes' => Mockery::self(),
|
|
|
|
|
'redirect' => Mockery::mock([
|
|
|
|
|
'getTargetUrl' => 'https://www.linkedin.com/oauth/v2/authorization?test=1',
|
|
|
|
|
]),
|
|
|
|
|
]));
|
|
|
|
|
|
|
|
|
|
$response = $this->actingAs($this->user)
|
|
|
|
|
->withHeader('X-Inertia', 'true')
|
2026-03-29 22:24:28 +00:00
|
|
|
->get(route('app.social.linkedin.connect'));
|
2026-01-18 18:56:51 +00:00
|
|
|
|
|
|
|
|
$response->assertStatus(409); // Inertia::location returns 409 with X-Inertia header
|
|
|
|
|
|
|
|
|
|
expect(session('social_connect_workspace'))->toBe($this->workspace->id);
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
test('linkedin oauth callback creates account', function () {
|
|
|
|
|
session([
|
|
|
|
|
'social_connect_workspace' => $this->workspace->id,
|
|
|
|
|
]);
|
|
|
|
|
|
|
|
|
|
$socialiteUser = Mockery::mock(SocialiteUser::class);
|
|
|
|
|
$socialiteUser->shouldReceive('getId')->andReturn('abc123xyz');
|
|
|
|
|
$socialiteUser->shouldReceive('getNickname')->andReturn(null);
|
|
|
|
|
$socialiteUser->shouldReceive('getName')->andReturn('John Doe');
|
|
|
|
|
$socialiteUser->shouldReceive('getAvatar')->andReturn(null);
|
|
|
|
|
$socialiteUser->token = 'test-access-token';
|
|
|
|
|
$socialiteUser->refreshToken = 'test-refresh-token';
|
|
|
|
|
$socialiteUser->expiresIn = 5184000; // 60 days
|
|
|
|
|
$socialiteUser->approvedScopes = ['openid', 'profile', 'email', 'w_member_social'];
|
|
|
|
|
|
|
|
|
|
Socialite::shouldReceive('driver')
|
|
|
|
|
->with('linkedin')
|
|
|
|
|
->andReturn(Mockery::mock([
|
|
|
|
|
'user' => $socialiteUser,
|
|
|
|
|
]));
|
|
|
|
|
|
|
|
|
|
Http::fake([
|
|
|
|
|
'https://api.linkedin.com/v2/me*' => Http::response([
|
|
|
|
|
'id' => 'abc123xyz',
|
|
|
|
|
'vanityName' => 'johndoe',
|
|
|
|
|
'localizedFirstName' => 'John',
|
|
|
|
|
'localizedLastName' => 'Doe',
|
|
|
|
|
], 200),
|
|
|
|
|
]);
|
|
|
|
|
|
2026-03-29 22:24:28 +00:00
|
|
|
$response = $this->actingAs($this->user)->get(route('app.social.linkedin.callback'));
|
2026-01-18 18:56:51 +00:00
|
|
|
|
|
|
|
|
$response->assertOk();
|
|
|
|
|
$response->assertViewIs('auth.social-callback');
|
|
|
|
|
$response->assertViewHas('success', true);
|
|
|
|
|
|
|
|
|
|
$this->assertDatabaseHas('social_accounts', [
|
|
|
|
|
'workspace_id' => $this->workspace->id,
|
|
|
|
|
'platform' => Platform::LinkedIn->value,
|
|
|
|
|
'platform_user_id' => 'abc123xyz',
|
|
|
|
|
'username' => 'johndoe',
|
|
|
|
|
'status' => Status::Connected->value,
|
|
|
|
|
]);
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
test('linkedin callback fails with expired session', function () {
|
|
|
|
|
// No session data - simulating expired session
|
|
|
|
|
|
2026-03-29 22:24:28 +00:00
|
|
|
$response = $this->actingAs($this->user)->get(route('app.social.linkedin.callback'));
|
2026-01-18 18:56:51 +00:00
|
|
|
|
|
|
|
|
$response->assertOk();
|
|
|
|
|
$response->assertViewHas('success', false);
|
|
|
|
|
$response->assertViewHas('message', 'Session expired. Please try again.');
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
test('user cannot connect linkedin if already connected', function () {
|
|
|
|
|
SocialAccount::factory()->linkedin()->create([
|
|
|
|
|
'workspace_id' => $this->workspace->id,
|
|
|
|
|
'platform_user_id' => 'abc123xyz',
|
|
|
|
|
]);
|
|
|
|
|
|
|
|
|
|
session([
|
|
|
|
|
'social_connect_workspace' => $this->workspace->id,
|
|
|
|
|
]);
|
|
|
|
|
|
|
|
|
|
$socialiteUser = Mockery::mock(SocialiteUser::class);
|
|
|
|
|
$socialiteUser->shouldReceive('getId')->andReturn('xyz789abc');
|
|
|
|
|
$socialiteUser->shouldReceive('getNickname')->andReturn(null);
|
|
|
|
|
$socialiteUser->shouldReceive('getName')->andReturn('Jane Doe');
|
|
|
|
|
$socialiteUser->shouldReceive('getAvatar')->andReturn(null);
|
|
|
|
|
$socialiteUser->token = 'new-access-token';
|
|
|
|
|
$socialiteUser->refreshToken = 'new-refresh-token';
|
|
|
|
|
$socialiteUser->expiresIn = 5184000;
|
|
|
|
|
|
|
|
|
|
Socialite::shouldReceive('driver')
|
|
|
|
|
->with('linkedin')
|
|
|
|
|
->andReturn(Mockery::mock([
|
|
|
|
|
'user' => $socialiteUser,
|
|
|
|
|
]));
|
|
|
|
|
|
2026-03-29 22:24:28 +00:00
|
|
|
$response = $this->actingAs($this->user)->get(route('app.social.linkedin.callback'));
|
2026-01-18 18:56:51 +00:00
|
|
|
|
|
|
|
|
$response->assertOk();
|
|
|
|
|
$response->assertViewHas('success', false);
|
|
|
|
|
$response->assertViewHas('message', 'This platform is already connected.');
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
test('user can reconnect disconnected linkedin account', function () {
|
|
|
|
|
$existingAccount = SocialAccount::factory()->linkedin()->disconnected()->create([
|
|
|
|
|
'workspace_id' => $this->workspace->id,
|
|
|
|
|
'platform_user_id' => 'abc123xyz',
|
|
|
|
|
]);
|
|
|
|
|
|
|
|
|
|
session([
|
|
|
|
|
'social_connect_workspace' => $this->workspace->id,
|
|
|
|
|
]);
|
|
|
|
|
|
|
|
|
|
$socialiteUser = Mockery::mock(SocialiteUser::class);
|
|
|
|
|
$socialiteUser->shouldReceive('getId')->andReturn('abc123xyz');
|
|
|
|
|
$socialiteUser->shouldReceive('getNickname')->andReturn(null);
|
|
|
|
|
$socialiteUser->shouldReceive('getName')->andReturn('John Doe');
|
|
|
|
|
$socialiteUser->shouldReceive('getAvatar')->andReturn(null);
|
|
|
|
|
$socialiteUser->token = 'new-access-token';
|
|
|
|
|
$socialiteUser->refreshToken = 'new-refresh-token';
|
|
|
|
|
$socialiteUser->expiresIn = 5184000;
|
|
|
|
|
$socialiteUser->approvedScopes = ['openid', 'profile', 'email', 'w_member_social'];
|
|
|
|
|
|
|
|
|
|
Socialite::shouldReceive('driver')
|
|
|
|
|
->with('linkedin')
|
|
|
|
|
->andReturn(Mockery::mock([
|
|
|
|
|
'user' => $socialiteUser,
|
|
|
|
|
]));
|
|
|
|
|
|
|
|
|
|
Http::fake([
|
|
|
|
|
'https://api.linkedin.com/v2/me*' => Http::response([
|
|
|
|
|
'vanityName' => 'johndoe',
|
|
|
|
|
], 200),
|
|
|
|
|
]);
|
|
|
|
|
|
2026-03-29 22:24:28 +00:00
|
|
|
$response = $this->actingAs($this->user)->get(route('app.social.linkedin.callback'));
|
2026-01-18 18:56:51 +00:00
|
|
|
|
|
|
|
|
$response->assertOk();
|
|
|
|
|
$response->assertViewHas('success', true);
|
|
|
|
|
|
|
|
|
|
$existingAccount->refresh();
|
|
|
|
|
expect($existingAccount->status)->toBe(Status::Connected);
|
|
|
|
|
expect($existingAccount->access_token)->toBe('new-access-token');
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
test('linkedin callback handles oauth errors gracefully', function () {
|
|
|
|
|
session([
|
|
|
|
|
'social_connect_workspace' => $this->workspace->id,
|
|
|
|
|
]);
|
|
|
|
|
|
|
|
|
|
$mock = Mockery::mock();
|
2026-03-29 22:24:28 +00:00
|
|
|
$mock->shouldReceive('user')->andThrow(new Exception('OAuth error'));
|
2026-01-18 18:56:51 +00:00
|
|
|
|
|
|
|
|
Socialite::shouldReceive('driver')
|
|
|
|
|
->with('linkedin')
|
|
|
|
|
->andReturn($mock);
|
|
|
|
|
|
2026-03-29 22:24:28 +00:00
|
|
|
$response = $this->actingAs($this->user)->get(route('app.social.linkedin.callback'));
|
2026-01-18 18:56:51 +00:00
|
|
|
|
|
|
|
|
$response->assertOk();
|
|
|
|
|
$response->assertViewHas('success', false);
|
|
|
|
|
$response->assertViewHas('message', 'Error connecting account. Please try again.');
|
|
|
|
|
});
|