Make the document (PDF) exclusivity validation — previously web-only — also apply when scheduling/publishing via the public API and MCP, so a misconfigured post can't slip through these entry points. - ContentTypeCompatibleWithMedia: stored-media fallback for partial updates + a stored-state assertStoredPostCompatible(Post) - MCP PublishPostTool: assert stored-state compatibility before publish (the media-side mirror of assertStoredPostPublishable) - API UpdatePostRequest: validate each platform's effective content_type against effective media on schedule/publish (covers publishing without resubmitting content_type) - MCP UpdatePostTool: apply the rule on schedule with stored-media fallback - Tests: API + MCP happy + rejection paths, plus rule fallback/precedence units
304 lines
13 KiB
PHP
304 lines
13 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Enums\Post\Status as PostStatus;
|
|
use App\Enums\PostPlatform\ContentType;
|
|
use App\Enums\SocialAccount\Platform;
|
|
use App\Jobs\PublishPost;
|
|
use App\Models\Post;
|
|
use App\Models\PostPlatform;
|
|
use App\Models\SocialAccount;
|
|
use Illuminate\Support\Facades\Queue;
|
|
|
|
beforeEach(function () {
|
|
$result = createApiTestToken();
|
|
$this->user = $result['user'];
|
|
$this->workspace = $result['workspace'];
|
|
$this->plainToken = $result['plain_token'];
|
|
|
|
$this->headers = ['Authorization' => 'Bearer '.$this->plainToken];
|
|
|
|
$this->discordAccount = SocialAccount::factory()->discord()->create([
|
|
'workspace_id' => $this->workspace->id,
|
|
'platform_user_id' => '111222333',
|
|
]);
|
|
});
|
|
|
|
it('persists Discord channel, mentions and embeds meta on store', function () {
|
|
$this->withHeaders($this->headers)
|
|
->postJson(route('api.posts.store'), [
|
|
'content' => 'Hello Discord',
|
|
'platforms' => [[
|
|
'social_account_id' => $this->discordAccount->id,
|
|
'content_type' => ContentType::DiscordMessage->value,
|
|
'meta' => [
|
|
'channel_id' => '444555666',
|
|
'mentions' => [['token' => '@everyone', 'label' => '@everyone']],
|
|
'embeds' => [['title' => 'Release', 'color' => '#5865F2']],
|
|
],
|
|
]],
|
|
])
|
|
->assertCreated();
|
|
|
|
$meta = PostPlatform::where('social_account_id', $this->discordAccount->id)->sole()->meta;
|
|
|
|
// Assert nested keys survive validated() — the exact stripping bug this PR fixes.
|
|
expect(data_get($meta, 'channel_id'))->toBe('444555666')
|
|
->and(data_get($meta, 'mentions.0.token'))->toBe('@everyone')
|
|
->and(data_get($meta, 'mentions.0.label'))->toBe('@everyone')
|
|
->and(data_get($meta, 'embeds.0.title'))->toBe('Release')
|
|
->and(data_get($meta, 'embeds.0.color'))->toBe('#5865F2');
|
|
});
|
|
|
|
it('persists the LinkedIn document_title meta on store', function () {
|
|
$linkedin = SocialAccount::factory()->create(['workspace_id' => $this->workspace->id, 'platform' => Platform::LinkedIn]);
|
|
|
|
$this->withHeaders($this->headers)
|
|
->postJson(route('api.posts.store'), [
|
|
'content' => 'Check our latest deck',
|
|
'platforms' => [[
|
|
'social_account_id' => $linkedin->id,
|
|
'content_type' => ContentType::LinkedInDocument->value,
|
|
'meta' => ['document_title' => 'Q2 Report'],
|
|
]],
|
|
])
|
|
->assertCreated();
|
|
|
|
expect(PostPlatform::where('social_account_id', $linkedin->id)->sole()->meta['document_title'])->toBe('Q2 Report');
|
|
});
|
|
|
|
it('publishes a LinkedIn document post that has a PDF', function () {
|
|
Queue::fake();
|
|
|
|
$linkedin = SocialAccount::factory()->create(['workspace_id' => $this->workspace->id, 'platform' => Platform::LinkedIn]);
|
|
$post = Post::factory()->create([
|
|
'workspace_id' => $this->workspace->id,
|
|
'user_id' => $this->user->id,
|
|
'content' => 'Our latest deck',
|
|
'media' => [[
|
|
'id' => 'doc-1', 'path' => 'medias/deck.pdf', 'url' => 'https://example.com/deck.pdf',
|
|
'type' => 'document', 'mime_type' => 'application/pdf', 'original_filename' => 'deck.pdf',
|
|
]],
|
|
]);
|
|
$platform = PostPlatform::factory()->create([
|
|
'post_id' => $post->id, 'social_account_id' => $linkedin->id,
|
|
'platform' => Platform::LinkedIn, 'content_type' => ContentType::LinkedInDocument, 'enabled' => true,
|
|
]);
|
|
|
|
$this->withHeaders($this->headers)
|
|
->putJson(route('api.posts.update', $post), [
|
|
'status' => PostStatus::Publishing->value,
|
|
'platforms' => [['id' => $platform->id, 'content_type' => ContentType::LinkedInDocument->value]],
|
|
])
|
|
->assertOk();
|
|
|
|
Queue::assertPushed(PublishPost::class);
|
|
});
|
|
|
|
it('rejects publishing a LinkedIn document post whose media is an image, not a PDF', function () {
|
|
$linkedin = SocialAccount::factory()->create(['workspace_id' => $this->workspace->id, 'platform' => Platform::LinkedIn]);
|
|
$post = Post::factory()->create([
|
|
'workspace_id' => $this->workspace->id,
|
|
'user_id' => $this->user->id,
|
|
'media' => [[
|
|
'id' => 'img-1', 'path' => 'medias/slide.jpg', 'url' => 'https://example.com/slide.jpg',
|
|
'type' => 'image', 'mime_type' => 'image/jpeg', 'original_filename' => 'slide.jpg',
|
|
]],
|
|
]);
|
|
$platform = PostPlatform::factory()->create([
|
|
'post_id' => $post->id, 'social_account_id' => $linkedin->id,
|
|
'platform' => Platform::LinkedIn, 'content_type' => ContentType::LinkedInDocument, 'enabled' => true,
|
|
]);
|
|
|
|
$this->withHeaders($this->headers)
|
|
->putJson(route('api.posts.update', $post), [
|
|
'status' => PostStatus::Publishing->value,
|
|
'platforms' => [['id' => $platform->id, 'content_type' => ContentType::LinkedInDocument->value]],
|
|
])
|
|
->assertUnprocessable()
|
|
->assertJsonValidationErrors(['platforms.0.content_type']);
|
|
});
|
|
|
|
it('rejects publishing a regular LinkedIn post that has a PDF attached', function () {
|
|
$linkedin = SocialAccount::factory()->create(['workspace_id' => $this->workspace->id, 'platform' => Platform::LinkedIn]);
|
|
$post = Post::factory()->create([
|
|
'workspace_id' => $this->workspace->id,
|
|
'user_id' => $this->user->id,
|
|
'media' => [[
|
|
'id' => 'doc-1', 'path' => 'medias/deck.pdf', 'url' => 'https://example.com/deck.pdf',
|
|
'type' => 'document', 'mime_type' => 'application/pdf', 'original_filename' => 'deck.pdf',
|
|
]],
|
|
]);
|
|
$platform = PostPlatform::factory()->create([
|
|
'post_id' => $post->id, 'social_account_id' => $linkedin->id,
|
|
'platform' => Platform::LinkedIn, 'content_type' => ContentType::LinkedInPost, 'enabled' => true,
|
|
]);
|
|
|
|
$this->withHeaders($this->headers)
|
|
->putJson(route('api.posts.update', $post), [
|
|
'status' => PostStatus::Publishing->value,
|
|
'platforms' => [['id' => $platform->id, 'content_type' => ContentType::LinkedInPost->value]],
|
|
])
|
|
->assertUnprocessable()
|
|
->assertJsonValidationErrors(['platforms.0.content_type']);
|
|
});
|
|
|
|
it('publishes a valid LinkedIn document without resubmitting content_type', function () {
|
|
Queue::fake();
|
|
|
|
$linkedin = SocialAccount::factory()->create(['workspace_id' => $this->workspace->id, 'platform' => Platform::LinkedIn]);
|
|
$post = Post::factory()->create([
|
|
'workspace_id' => $this->workspace->id,
|
|
'user_id' => $this->user->id,
|
|
'content' => 'Our deck',
|
|
'media' => [[
|
|
'id' => 'doc-1', 'path' => 'medias/deck.pdf', 'url' => 'https://example.com/deck.pdf',
|
|
'type' => 'document', 'mime_type' => 'application/pdf', 'original_filename' => 'deck.pdf',
|
|
]],
|
|
]);
|
|
$platform = PostPlatform::factory()->create([
|
|
'post_id' => $post->id, 'social_account_id' => $linkedin->id,
|
|
'platform' => Platform::LinkedIn, 'content_type' => ContentType::LinkedInDocument, 'enabled' => true,
|
|
]);
|
|
|
|
$this->withHeaders($this->headers)
|
|
->putJson(route('api.posts.update', $post), [
|
|
'status' => PostStatus::Publishing->value,
|
|
'platforms' => [['id' => $platform->id]],
|
|
])
|
|
->assertOk();
|
|
|
|
Queue::assertPushed(PublishPost::class);
|
|
});
|
|
|
|
it('rejects publishing a misconfigured post even when content_type is not resubmitted', function () {
|
|
$linkedin = SocialAccount::factory()->create(['workspace_id' => $this->workspace->id, 'platform' => Platform::LinkedIn]);
|
|
$post = Post::factory()->create([
|
|
'workspace_id' => $this->workspace->id,
|
|
'user_id' => $this->user->id,
|
|
'media' => [[
|
|
'id' => 'doc-1', 'path' => 'medias/deck.pdf', 'url' => 'https://example.com/deck.pdf',
|
|
'type' => 'document', 'mime_type' => 'application/pdf', 'original_filename' => 'deck.pdf',
|
|
]],
|
|
]);
|
|
// Stored as a regular post but carrying a PDF — the client publishes without resubmitting content_type.
|
|
$platform = PostPlatform::factory()->create([
|
|
'post_id' => $post->id, 'social_account_id' => $linkedin->id,
|
|
'platform' => Platform::LinkedIn, 'content_type' => ContentType::LinkedInPost, 'enabled' => true,
|
|
]);
|
|
|
|
$this->withHeaders($this->headers)
|
|
->putJson(route('api.posts.update', $post), [
|
|
'status' => PostStatus::Publishing->value,
|
|
'platforms' => [['id' => $platform->id]],
|
|
])
|
|
->assertUnprocessable()
|
|
->assertJsonValidationErrors(['platforms.0.content_type']);
|
|
});
|
|
|
|
it('persists per-platform meta across networks on store', function () {
|
|
$instagram = SocialAccount::factory()->create(['workspace_id' => $this->workspace->id, 'platform' => Platform::Instagram]);
|
|
$pinterest = SocialAccount::factory()->create(['workspace_id' => $this->workspace->id, 'platform' => Platform::Pinterest]);
|
|
$tiktok = SocialAccount::factory()->create(['workspace_id' => $this->workspace->id, 'platform' => Platform::TikTok]);
|
|
|
|
$this->withHeaders($this->headers)
|
|
->postJson(route('api.posts.store'), [
|
|
'content' => 'Cross-platform',
|
|
'platforms' => [
|
|
['social_account_id' => $instagram->id, 'content_type' => ContentType::InstagramFeed->value, 'meta' => ['aspect_ratio' => '4:5']],
|
|
['social_account_id' => $pinterest->id, 'content_type' => ContentType::PinterestPin->value, 'meta' => ['board_id' => 'board-99']],
|
|
['social_account_id' => $tiktok->id, 'content_type' => ContentType::TikTokVideo->value, 'meta' => ['privacy_level' => 'SELF_ONLY', 'allow_comments' => true]],
|
|
],
|
|
])
|
|
->assertCreated();
|
|
|
|
expect(PostPlatform::where('social_account_id', $instagram->id)->sole()->meta['aspect_ratio'])->toBe('4:5')
|
|
->and(PostPlatform::where('social_account_id', $pinterest->id)->sole()->meta['board_id'])->toBe('board-99')
|
|
->and(PostPlatform::where('social_account_id', $tiktok->id)->sole()->meta['privacy_level'])->toBe('SELF_ONLY')
|
|
->and(PostPlatform::where('social_account_id', $tiktok->id)->sole()->meta['allow_comments'])->toBeTrue();
|
|
});
|
|
|
|
it('allows saving a Discord draft without a channel', function () {
|
|
$post = Post::factory()->create(['workspace_id' => $this->workspace->id, 'user_id' => $this->user->id]);
|
|
$platform = PostPlatform::factory()->discord()->create([
|
|
'post_id' => $post->id,
|
|
'social_account_id' => $this->discordAccount->id,
|
|
'enabled' => true,
|
|
'meta' => [],
|
|
]);
|
|
|
|
$this->withHeaders($this->headers)
|
|
->putJson(route('api.posts.update', $post), [
|
|
'status' => PostStatus::Draft->value,
|
|
'platforms' => [['id' => $platform->id]],
|
|
])
|
|
->assertOk();
|
|
});
|
|
|
|
it('rejects publishing without TikTok privacy and Pinterest board', function () {
|
|
$pinterest = SocialAccount::factory()->create(['workspace_id' => $this->workspace->id, 'platform' => Platform::Pinterest]);
|
|
$tiktok = SocialAccount::factory()->create(['workspace_id' => $this->workspace->id, 'platform' => Platform::TikTok]);
|
|
|
|
$post = Post::factory()->create(['workspace_id' => $this->workspace->id, 'user_id' => $this->user->id]);
|
|
$pinterestPlatform = PostPlatform::factory()->pinterest()->create([
|
|
'post_id' => $post->id, 'social_account_id' => $pinterest->id, 'enabled' => true, 'meta' => [],
|
|
]);
|
|
$tiktokPlatform = PostPlatform::factory()->tiktok()->create([
|
|
'post_id' => $post->id, 'social_account_id' => $tiktok->id, 'enabled' => true, 'meta' => [],
|
|
]);
|
|
|
|
$this->withHeaders($this->headers)
|
|
->putJson(route('api.posts.update', $post), [
|
|
'status' => PostStatus::Publishing->value,
|
|
'platforms' => [
|
|
['id' => $pinterestPlatform->id],
|
|
['id' => $tiktokPlatform->id],
|
|
],
|
|
])
|
|
->assertUnprocessable()
|
|
->assertJsonValidationErrors([
|
|
'platforms.0.meta.board_id',
|
|
'platforms.1.meta.privacy_level',
|
|
]);
|
|
});
|
|
|
|
it('rejects publishing a Discord post without a channel', function () {
|
|
$post = Post::factory()->create(['workspace_id' => $this->workspace->id, 'user_id' => $this->user->id]);
|
|
$platform = PostPlatform::factory()->discord()->create([
|
|
'post_id' => $post->id,
|
|
'social_account_id' => $this->discordAccount->id,
|
|
'enabled' => true,
|
|
'meta' => [],
|
|
]);
|
|
|
|
$this->withHeaders($this->headers)
|
|
->putJson(route('api.posts.update', $post), [
|
|
'status' => PostStatus::Publishing->value,
|
|
'platforms' => [['id' => $platform->id]],
|
|
])
|
|
->assertUnprocessable()
|
|
->assertJsonValidationErrors(['platforms.0.meta.channel_id']);
|
|
});
|
|
|
|
it('publishes a Discord post when the channel is set', function () {
|
|
Queue::fake();
|
|
|
|
$post = Post::factory()->create(['workspace_id' => $this->workspace->id, 'user_id' => $this->user->id]);
|
|
$platform = PostPlatform::factory()->discord()->create([
|
|
'post_id' => $post->id,
|
|
'social_account_id' => $this->discordAccount->id,
|
|
'enabled' => true,
|
|
'meta' => [],
|
|
]);
|
|
|
|
$this->withHeaders($this->headers)
|
|
->putJson(route('api.posts.update', $post), [
|
|
'status' => PostStatus::Publishing->value,
|
|
'platforms' => [['id' => $platform->id, 'meta' => ['channel_id' => '444555666']]],
|
|
])
|
|
->assertOk();
|
|
|
|
expect($platform->fresh()->meta['channel_id'])->toBe('444555666');
|
|
Queue::assertPushed(PublishPost::class);
|
|
});
|