Bugs (both with regression tests): - OnboardingController::store now guards already-subscribed accounts (mirrors index), preventing a second Stripe Checkout / double subscription if a subscribed user re-POSTs /onboarding. - SocialAccountObserver: drop the `platform_user_id != …` clause from the creating-time one-per-network check. On create there is no "self" to exclude, so it only weakened the rule — the same account connected via two network variants (e.g. Instagram standalone + via Facebook, same id) could slip a second account into the network. Now any account in the network blocks. Robustness: - CreateWorkspace wraps create + member attach + switchWorkspace in a transaction (cache-forget / quantity-sync run after), so a partial failure can't leave an orphan workspace that inflates the Stripe seat count — covers both the signup and the add-workspace paths. Test honesty & coverage: - Scope the ten "connect multiple <platform> accounts" tests to self-hosted mode (config + name); they only passed because the test env defaults SELF_HOSTED=true, and in cloud the one-per-network rule blocks them. - network_taken popup now has controller-level tests on all six OAuth controllers (added Threads, YouTube, LinkedInPage, and a new InstagramFacebook test file; LinkedInPage/InstagramFacebook also exercise variant collapse). - Wiring tests that creating/deleting a workspace actually calls syncWorkspaceQuantity (guards per-seat billing against silent breakage). - Strengthen TrialLengthTest to assert the configured length reaches trial_ends_at; add a same-id network-variant block test.
218 lines
7.2 KiB
PHP
218 lines
7.2 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Enums\SocialAccount\Platform;
|
|
use App\Enums\SocialAccount\Status;
|
|
use App\Enums\UserWorkspace\Role;
|
|
use App\Models\SocialAccount;
|
|
use App\Models\User;
|
|
use App\Models\Workspace;
|
|
use Illuminate\Support\Facades\Http;
|
|
|
|
beforeEach(function () {
|
|
$this->user = User::factory()->create();
|
|
$this->workspace = Workspace::factory()->create(['user_id' => $this->user->id]);
|
|
$this->user->update(['current_workspace_id' => $this->workspace->id]);
|
|
$this->workspace->members()->attach($this->user->id, ['role' => Role::Member->value]);
|
|
});
|
|
|
|
test('threads connect redirects to oauth', function () {
|
|
$response = $this->actingAs($this->user)
|
|
->withHeader('X-Inertia', 'true')
|
|
->get(route('app.social.threads.connect'));
|
|
|
|
$response->assertStatus(409); // Inertia::location returns 409 with X-Inertia header
|
|
|
|
expect(session('social_connect_workspace'))->toBe($this->workspace->id);
|
|
expect(session('threads_oauth_state'))->not->toBeNull();
|
|
});
|
|
|
|
test('threads oauth callback creates account', function () {
|
|
$state = bin2hex(random_bytes(16));
|
|
|
|
session([
|
|
'social_connect_workspace' => $this->workspace->id,
|
|
'threads_oauth_state' => $state,
|
|
]);
|
|
|
|
Http::fake([
|
|
'https://graph.threads.net/oauth/access_token' => Http::response([
|
|
'access_token' => 'short-lived-token',
|
|
'user_id' => '123456789',
|
|
], 200),
|
|
'https://graph.threads.net/access_token*' => Http::response([
|
|
'access_token' => 'long-lived-token',
|
|
'expires_in' => 5184000, // 60 days
|
|
], 200),
|
|
'https://graph.threads.net/v1.0/123456789*' => Http::response([
|
|
'id' => '123456789',
|
|
'username' => 'testuser',
|
|
'name' => 'Test User',
|
|
'threads_profile_picture_url' => null,
|
|
], 200),
|
|
]);
|
|
|
|
$response = $this->actingAs($this->user)->get(route('app.social.threads.callback', [
|
|
'code' => 'test-auth-code',
|
|
'state' => $state,
|
|
]));
|
|
|
|
$response->assertOk();
|
|
$response->assertViewIs('auth.social-callback');
|
|
$response->assertViewHas('success', true);
|
|
|
|
$this->assertDatabaseHas('social_accounts', [
|
|
'workspace_id' => $this->workspace->id,
|
|
'platform' => Platform::Threads->value,
|
|
'platform_user_id' => '123456789',
|
|
'username' => 'testuser',
|
|
'status' => Status::Connected->value,
|
|
]);
|
|
});
|
|
|
|
test('threads callback fails with invalid state', function () {
|
|
session([
|
|
'social_connect_workspace' => $this->workspace->id,
|
|
'threads_oauth_state' => 'correct-state',
|
|
]);
|
|
|
|
$response = $this->actingAs($this->user)->get(route('app.social.threads.callback', [
|
|
'code' => 'test-auth-code',
|
|
'state' => 'wrong-state',
|
|
]));
|
|
|
|
$response->assertOk();
|
|
$response->assertViewHas('success', false);
|
|
$response->assertViewHas('message', 'Invalid state. Please try again.');
|
|
|
|
$this->assertDatabaseMissing('social_accounts', [
|
|
'workspace_id' => $this->workspace->id,
|
|
'platform' => Platform::Threads->value,
|
|
]);
|
|
});
|
|
|
|
test('threads callback fails with expired session', function () {
|
|
// No session data - simulating expired session
|
|
|
|
$response = $this->actingAs($this->user)->get(route('app.social.threads.callback', [
|
|
'code' => 'test-auth-code',
|
|
'state' => 'test-state',
|
|
]));
|
|
|
|
$response->assertOk();
|
|
$response->assertViewHas('success', false);
|
|
$response->assertViewHas('message', 'Session expired. Please try again.');
|
|
});
|
|
|
|
test('user can connect multiple threads accounts in self-hosted mode', function () {
|
|
config()->set('trypost.self_hosted', true);
|
|
|
|
SocialAccount::factory()->threads()->create([
|
|
'workspace_id' => $this->workspace->id,
|
|
'platform_user_id' => '123456789',
|
|
]);
|
|
|
|
$state = bin2hex(random_bytes(16));
|
|
|
|
session([
|
|
'social_connect_workspace' => $this->workspace->id,
|
|
'threads_oauth_state' => $state,
|
|
]);
|
|
|
|
Http::fake([
|
|
'https://graph.threads.net/oauth/access_token' => Http::response([
|
|
'access_token' => 'new-token',
|
|
'user_id' => '987654321',
|
|
], 200),
|
|
'https://graph.threads.net/access_token*' => Http::response([
|
|
'access_token' => 'long-lived-token',
|
|
'expires_in' => 5184000,
|
|
], 200),
|
|
'https://graph.threads.net/v1.0/987654321*' => Http::response([
|
|
'id' => '987654321',
|
|
'username' => 'anotheruser',
|
|
'name' => 'Another User',
|
|
], 200),
|
|
]);
|
|
|
|
$response = $this->actingAs($this->user)->get(route('app.social.threads.callback', [
|
|
'code' => 'test-auth-code',
|
|
'state' => $state,
|
|
]));
|
|
|
|
$response->assertOk();
|
|
$response->assertViewHas('success', true);
|
|
|
|
expect($this->workspace->socialAccounts()->where('platform', Platform::Threads)->count())->toBe(2);
|
|
});
|
|
|
|
test('threads callback handles token exchange failure', function () {
|
|
$state = bin2hex(random_bytes(16));
|
|
|
|
session([
|
|
'social_connect_workspace' => $this->workspace->id,
|
|
'threads_oauth_state' => $state,
|
|
]);
|
|
|
|
Http::fake([
|
|
'https://graph.threads.net/oauth/access_token' => Http::response([
|
|
'error' => 'invalid_grant',
|
|
'error_description' => 'The authorization code has expired.',
|
|
], 400),
|
|
]);
|
|
|
|
$response = $this->actingAs($this->user)->get(route('app.social.threads.callback', [
|
|
'code' => 'expired-auth-code',
|
|
'state' => $state,
|
|
]));
|
|
|
|
$response->assertOk();
|
|
$response->assertViewHas('success', false);
|
|
$response->assertViewHas('message', 'Error connecting account. Please try again.');
|
|
});
|
|
|
|
test('threads callback shows network_taken when the network is already connected', function () {
|
|
config()->set('trypost.self_hosted', false);
|
|
|
|
SocialAccount::factory()->threads()->create([
|
|
'workspace_id' => $this->workspace->id,
|
|
'platform_user_id' => 'existing-threads',
|
|
]);
|
|
|
|
$state = bin2hex(random_bytes(16));
|
|
|
|
session([
|
|
'social_connect_workspace' => $this->workspace->id,
|
|
'threads_oauth_state' => $state,
|
|
]);
|
|
|
|
Http::fake([
|
|
'https://graph.threads.net/oauth/access_token' => Http::response([
|
|
'access_token' => 'short-lived-token',
|
|
'user_id' => '123456789',
|
|
], 200),
|
|
'https://graph.threads.net/access_token*' => Http::response([
|
|
'access_token' => 'long-lived-token',
|
|
'expires_in' => 5184000,
|
|
], 200),
|
|
'https://graph.threads.net/v1.0/123456789*' => Http::response([
|
|
'id' => '123456789',
|
|
'username' => 'testuser',
|
|
'name' => 'Test User',
|
|
'threads_profile_picture_url' => null,
|
|
], 200),
|
|
]);
|
|
|
|
$response = $this->actingAs($this->user)->get(route('app.social.threads.callback', [
|
|
'code' => 'test-auth-code',
|
|
'state' => $state,
|
|
]));
|
|
|
|
$response->assertOk();
|
|
$response->assertViewIs('auth.social-callback');
|
|
$response->assertViewHas('success', false);
|
|
$response->assertViewHas('message', __('accounts.popup_callback.network_taken'));
|
|
|
|
expect($this->workspace->socialAccounts()->where('platform', Platform::Threads)->count())->toBe(1);
|
|
});
|