trypost/app/Http/Controllers/Api/PostController.php
Paulo Castellano 3b96a9ebdb refactor: move workspace tenancy check on Post into PostPolicy
The same "is this post in the user's current workspace?" check was
duplicated across every Post-related endpoint (5 in Api/PostController
via the ensurePostInCurrentWorkspace helper, 5 in App/PostController
inline). PostPolicy already had a duplicate() method following this
exact pattern — extending it with view/update/delete unifies the
tenancy guard in one place.

- Add view/update/delete to PostPolicy. Each returns
  Response::denyAsNotFound() when the post belongs to a different
  workspace, so we keep the existing 404 behavior (don't leak
  cross-tenant existence) instead of switching to the default 403.

- Update duplicate() to also use denyAsNotFound() for the workspace
  mismatch path. The createPost role check still returns bool/403.

- Replace ensurePostInCurrentWorkspace() calls in Api/PostController
  with $this->authorize('view'|'update'|'delete', $post). Helper deleted.

- Replace inline workspace_id !== $workspace->id checks in
  App/PostController (show/edit/update/destroy/platformMetrics) with
  the same authorize calls. The PostPolicy guard now subsumes both
  the workspace-tenancy check and the role-permission check that was
  previously delegated through Workspace::createPost.
2026-05-04 13:20:52 -03:00

118 lines
3.5 KiB
PHP

<?php
declare(strict_types=1);
namespace App\Http\Controllers\Api;
use App\Actions\Post\CreatePost;
use App\Actions\Post\DeletePost;
use App\Actions\Post\UpdatePost;
use App\Enums\Post\Action as PostAction;
use App\Http\Requests\Api\Post\StorePostRequest;
use App\Http\Requests\Api\Post\UpdatePostRequest;
use App\Http\Resources\Api\PostMediaAttachResource;
use App\Http\Resources\Api\PostMetricsResource;
use App\Http\Resources\Api\PostPreviewResource;
use App\Http\Resources\Api\PostResource;
use App\Models\Post;
use App\Services\Post\MediaAttacher;
use Illuminate\Http\JsonResponse;
use Illuminate\Http\Request;
use Illuminate\Http\Resources\Json\AnonymousResourceCollection;
use Symfony\Component\HttpFoundation\Response;
class PostController extends Controller
{
public function index(Request $request): AnonymousResourceCollection
{
$posts = $request->user()->currentWorkspace->posts()
->with(['postPlatforms.socialAccount', 'user', 'labels'])
->latest('scheduled_at')
->paginate(15);
return PostResource::collection($posts);
}
public function show(Request $request, Post $post): PostResource
{
$this->authorize('view', $post);
$post->load(['postPlatforms.socialAccount', 'user', 'labels']);
return new PostResource($post);
}
public function store(StorePostRequest $request): JsonResponse
{
$post = CreatePost::execute(
$request->user()->currentWorkspace,
$request->user()->currentWorkspace->owner,
$request->validated()
);
$post->load(['postPlatforms.socialAccount']);
return (new PostResource($post))
->response()
->setStatusCode(Response::HTTP_CREATED);
}
public function update(UpdatePostRequest $request, Post $post): PostResource|JsonResponse
{
$this->authorize('update', $post);
$result = UpdatePost::execute($request->user()->currentWorkspace, $post, $request->validated());
if (data_get($result, 'action') === PostAction::AlreadyPublished) {
return response()->json(
['message' => 'Cannot edit a published post.'],
Response::HTTP_UNPROCESSABLE_ENTITY
);
}
return new PostResource(data_get($result, 'post'));
}
public function destroy(Request $request, Post $post): JsonResponse
{
$this->authorize('delete', $post);
DeletePost::execute($post);
return response()->json(null, Response::HTTP_NO_CONTENT);
}
public function attachMedia(Request $request, Post $post): PostMediaAttachResource
{
$this->authorize('update', $post);
$validated = $request->validate([
'urls' => ['required', 'array', 'min:1', 'max:10'],
'urls.*' => ['url:http,https'],
]);
$result = app(MediaAttacher::class)->attachFromUrls($post, $validated['urls']);
$post->refresh()->load(['postPlatforms.socialAccount', 'labels']);
return new PostMediaAttachResource($post, $result);
}
public function metrics(Request $request, Post $post): PostMetricsResource
{
$this->authorize('view', $post);
$post->load(['postPlatforms.socialAccount']);
return new PostMetricsResource($post);
}
public function preview(Request $request, Post $post): PostPreviewResource
{
$this->authorize('view', $post);
$post->load(['postPlatforms.socialAccount']);
return new PostPreviewResource($post);
}
}