trypost/app/Http/Controllers/App/WorkspaceController.php
Paulo Castellano 3bc481ac07 Make LogoAttacher honor its swallow-all contract; drop the caller try/catch
LogoAttacher::attach promised in its docblock that any failure — including a
persistence error — is logged and swallowed so the caller need not handle it.
But the persistence block was try/finally with no catch, so a Throwable from
clearMediaCollection/addMediaFromPath escaped. Both call sites (store and
updateSettings) each wrapped the call in an identical try/catch + Log::warning
to compensate — a band-aid duplicated across the controller.

Fix it at the root: the persistence block now catches Throwable, logs it, and
returns false, matching the documented contract. Both controller call sites
collapse to a single attach() line, and the now-unused Log/Throwable imports
are dropped.

Adds LogoAttacherTest covering the success path, the swallowed persistence
failure, a failed fetch, and a rejected mime type.
2026-07-03 20:15:37 -03:00

231 lines
7.2 KiB
PHP

<?php
declare(strict_types=1);
namespace App\Http\Controllers\App;
use App\Actions\Ai\AutofillBrand;
use App\Actions\Workspace\CreateWorkspace;
use App\Actions\Workspace\DeleteWorkspace;
use App\Enums\Workspace\BrandFont;
use App\Enums\Workspace\BrandVoiceTrait;
use App\Enums\Workspace\ContentLanguage;
use App\Enums\Workspace\ImageStyle;
use App\Http\Requests\App\Workspace\AutofillBrandRequest;
use App\Http\Requests\App\Workspace\StoreWorkspaceRequest;
use App\Http\Requests\App\Workspace\UpdateWorkspaceRequest;
use App\Http\Resources\App\WorkspaceMemberResource;
use App\Models\Workspace;
use App\Services\Brand\LogoAttacher;
use Illuminate\Http\JsonResponse;
use Illuminate\Http\RedirectResponse;
use Illuminate\Http\Request;
use Illuminate\Http\Resources\Json\AnonymousResourceCollection;
use Inertia\Inertia;
use Inertia\Response;
use RuntimeException;
use Symfony\Component\HttpFoundation\Response as SymfonyResponse;
class WorkspaceController extends Controller
{
public function searchMembers(Request $request): AnonymousResourceCollection
{
$workspace = $request->user()->currentWorkspace;
abort_if(! $workspace, SymfonyResponse::HTTP_FORBIDDEN);
$this->authorize('view', $workspace);
$term = trim((string) $request->input('q', ''));
$members = $workspace->members()
->where('users.id', '!=', $request->user()->id)
->when($term !== '', fn ($query) => $query->where('users.name', 'ilike', '%'.$term.'%'))
->orderBy('users.name')
->limit(50)
->get(['users.id', 'users.name', 'users.email']);
return WorkspaceMemberResource::collection($members);
}
public function index(Request $request): Response
{
$user = $request->user();
$workspaces = $user->workspaces()
->with('media')
->withCount(['socialAccounts', 'posts'])
->latest()
->get();
return Inertia::render('workspaces/Index', [
'workspaces' => $workspaces,
'currentWorkspaceId' => $user->current_workspace_id,
]);
}
public function create(Request $request): Response|RedirectResponse
{
$user = $request->user();
if (! config('trypost.self_hosted')
&& $user->ownedWorkspacesCount() > 0
&& ! $user->account?->hasActiveSubscription()) {
return redirect()->route('app.billing.index')
->with('message', 'Subscribe to create more workspaces.');
}
return Inertia::render('workspaces/Create', [
'availableFonts' => BrandFont::values(),
'availableImageStyles' => ImageStyle::values(),
'availableVoiceTraits' => BrandVoiceTrait::grouped(),
'availableContentLanguages' => ContentLanguage::options(),
]);
}
public function autofillBrand(AutofillBrandRequest $request, AutofillBrand $autofill): JsonResponse
{
try {
$metadata = $autofill($request->validated('url'));
} catch (RuntimeException $e) {
return response()->json(['message' => $e->getMessage()], SymfonyResponse::HTTP_UNPROCESSABLE_ENTITY);
}
return response()->json($metadata->toArray());
}
public function store(StoreWorkspaceRequest $request, LogoAttacher $logoAttacher): RedirectResponse
{
$user = $request->user();
$validated = $request->validated();
$workspace = CreateWorkspace::execute($user, $validated);
if ($logoUrl = data_get($validated, 'logo_url')) {
$logoAttacher->attach($workspace, $logoUrl);
}
return redirect()->route('app.accounts')
->with('success', __('workspaces.create.success'));
}
public function switch(Request $request, Workspace $workspace): RedirectResponse
{
$user = $request->user();
if (! $user->belongsToWorkspace($workspace)) {
abort(403);
}
$user->switchWorkspace($workspace);
return redirect()->route('app.calendar');
}
public function settings(Request $request): Response|RedirectResponse
{
$user = $request->user();
$workspace = $user->currentWorkspace;
if (! $workspace) {
return redirect()->route('app.workspaces.create');
}
$this->authorize('update', $workspace);
return Inertia::render('settings/workspace/Workspace', [
'workspace' => $workspace,
]);
}
public function brandSettings(Request $request): Response|RedirectResponse
{
$user = $request->user();
$workspace = $user->currentWorkspace;
if (! $workspace) {
return redirect()->route('app.workspaces.create');
}
$this->authorize('update', $workspace);
return Inertia::render('settings/workspace/Brand', [
'workspace' => $workspace,
'availableFonts' => BrandFont::values(),
'availableImageStyles' => ImageStyle::values(),
'availableVoiceTraits' => BrandVoiceTrait::grouped(),
'availableContentLanguages' => ContentLanguage::options(),
]);
}
public function uploadLogo(Request $request): RedirectResponse
{
$workspace = $request->user()->currentWorkspace;
$this->authorize('update', $workspace);
$request->validate([
'photo' => ['required', 'image', 'max:2048'],
]);
$workspace->clearMediaCollection('logo');
$workspace->addMedia($request->file('photo'), 'logo');
$workspace->unsetRelation('media');
return back()->with('flash.success', __('settings.flash.logo_updated'));
}
public function deleteLogo(Request $request): RedirectResponse
{
$workspace = $request->user()->currentWorkspace;
$this->authorize('update', $workspace);
$workspace->clearMediaCollection('logo');
$workspace->unsetRelation('media');
return back()->with('flash.success', __('settings.flash.logo_deleted'));
}
public function updateSettings(UpdateWorkspaceRequest $request, LogoAttacher $logoAttacher): RedirectResponse
{
$user = $request->user();
$workspace = $user->currentWorkspace;
if (! $workspace) {
return redirect()->route('app.workspaces.create');
}
$this->authorize('update', $workspace);
$validated = $request->validated();
$logoUrl = data_get($validated, 'logo_url');
unset($validated['logo_url']);
$workspace->update($validated);
if ($logoUrl) {
$logoAttacher->attach($workspace, $logoUrl);
}
return back()->with('flash.success', __('settings.flash.workspace_updated'));
}
public function destroy(Request $request, Workspace $workspace): RedirectResponse
{
$this->authorize('delete', $workspace);
$user = $request->user();
if (! config('trypost.self_hosted') && $workspace->account->workspaces()->count() <= 1) {
return back()->with('flash.error', __('workspaces.cannot_delete_last'));
}
DeleteWorkspace::execute($user, $workspace);
return redirect()->route('app.workspaces.index')
->with('flash.success', __('workspaces.flash.deleted'));
}
}