3f6032c152
Production incident: a customer's Facebook Page post failed with 'The post is empty. Please enter a message to share.' (error code 197) and ended up with a contradictory DB state (status=published + error_message=set). Three independent bugs were uncovered: A. FacebookPublisher sends 'message'/'description' as null when the user posts media without text. Graph API requires the key be omitted, not null. Fixed in publishSingleImagePost, publishMultiImagePost, publishVideoPost, publishReel. B. markAsPublished/markAsFailed leak stale fields across transitions (a published row could retain error_message from a prior failure, vice-versa). Both transitions now explicitly clear the opposite side's fields. C. status='failed' was editable in the UI and the backend, so users were re-clicking Publish, generating duplicate failure emails and the contradictory state from bug B. The frontend isReadOnly check and the UpdatePost backend guard now treat Published/PartiallyPublished/ Failed/Publishing as terminal. To retry, the user duplicates the post. 11 new tests guarantee these can't regress silently: FB payload shape per content type, PostPlatform field-clearing on transitions, and the terminal-status block at the controller level.
86 lines
2.9 KiB
PHP
86 lines
2.9 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
namespace App\Actions\Post;
|
|
|
|
use App\Enums\Post\Action as PostAction;
|
|
use App\Enums\Post\Status as PostStatus;
|
|
use App\Jobs\PublishPost;
|
|
use App\Models\Post;
|
|
use App\Models\Workspace;
|
|
use Carbon\Carbon;
|
|
use Illuminate\Support\Arr;
|
|
use Illuminate\Support\Facades\DB;
|
|
|
|
class UpdatePost
|
|
{
|
|
/**
|
|
* @return array{post: Post, action: PostAction|null}
|
|
*/
|
|
public static function execute(Workspace $workspace, Post $post, array $data): array
|
|
{
|
|
$terminalStatuses = [PostStatus::Published, PostStatus::PartiallyPublished, PostStatus::Failed, PostStatus::Publishing];
|
|
|
|
if (in_array($post->status, $terminalStatuses, true)) {
|
|
return ['post' => $post, 'action' => PostAction::Finalized];
|
|
}
|
|
|
|
$scheduledAt = $post->scheduled_at;
|
|
if (data_get($data, 'scheduled_at')) {
|
|
$scheduledAt = Carbon::parse(data_get($data, 'scheduled_at'))->utc();
|
|
}
|
|
|
|
$status = data_get($data, 'status', $post->status);
|
|
|
|
$post->update([
|
|
'content' => data_get($data, 'content', $post->content),
|
|
'media' => data_get($data, 'media', $post->media),
|
|
'status' => $status === PostStatus::Publishing->value ? PostStatus::Publishing : $status,
|
|
'scheduled_at' => $scheduledAt,
|
|
]);
|
|
|
|
if (Arr::has($data, 'label_ids')) {
|
|
$post->labels()->sync(data_get($data, 'label_ids', []));
|
|
}
|
|
|
|
if (Arr::has($data, 'platforms')) {
|
|
DB::transaction(function () use ($post, $data) {
|
|
$post->postPlatforms()->update(['enabled' => false]);
|
|
|
|
foreach (data_get($data, 'platforms', []) as $platformData) {
|
|
$updateData = ['enabled' => true];
|
|
|
|
if (data_get($platformData, 'content_type') !== null) {
|
|
$updateData['content_type'] = data_get($platformData, 'content_type');
|
|
}
|
|
|
|
if (data_get($platformData, 'meta') !== null) {
|
|
$postPlatform = $post->postPlatforms()->where('id', data_get($platformData, 'id'))->first();
|
|
|
|
if ($postPlatform) {
|
|
$updateData['meta'] = array_merge($postPlatform->meta ?? [], data_get($platformData, 'meta'));
|
|
}
|
|
}
|
|
|
|
$post->postPlatforms()
|
|
->where('id', data_get($platformData, 'id'))
|
|
->update($updateData);
|
|
}
|
|
});
|
|
}
|
|
|
|
if ($status === PostStatus::Publishing->value) {
|
|
$post->update(['scheduled_at' => now()]);
|
|
PublishPost::dispatch($post);
|
|
|
|
return ['post' => $post, 'action' => PostAction::Publishing];
|
|
}
|
|
|
|
if ($status === PostStatus::Scheduled->value) {
|
|
return ['post' => $post, 'action' => PostAction::Scheduled];
|
|
}
|
|
|
|
return ['post' => $post, 'action' => null];
|
|
}
|
|
}
|