3f6032c152
Production incident: a customer's Facebook Page post failed with 'The post is empty. Please enter a message to share.' (error code 197) and ended up with a contradictory DB state (status=published + error_message=set). Three independent bugs were uncovered: A. FacebookPublisher sends 'message'/'description' as null when the user posts media without text. Graph API requires the key be omitted, not null. Fixed in publishSingleImagePost, publishMultiImagePost, publishVideoPost, publishReel. B. markAsPublished/markAsFailed leak stale fields across transitions (a published row could retain error_message from a prior failure, vice-versa). Both transitions now explicitly clear the opposite side's fields. C. status='failed' was editable in the UI and the backend, so users were re-clicking Publish, generating duplicate failure emails and the contradictory state from bug B. The frontend isReadOnly check and the UpdatePost backend guard now treat Published/PartiallyPublished/ Failed/Publishing as terminal. To retry, the user duplicates the post. 11 new tests guarantee these can't regress silently: FB payload shape per content type, PostPlatform field-clearing on transitions, and the terminal-status block at the controller level.
89 lines
4.1 KiB
PHP
89 lines
4.1 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
namespace App\Mcp\Tools\Post;
|
|
|
|
use App\Actions\Post\UpdatePost;
|
|
use App\Enums\Post\Action as PostAction;
|
|
use App\Enums\Post\Status;
|
|
use App\Enums\PostPlatform\ContentType;
|
|
use App\Http\Resources\Api\PostResource;
|
|
use App\Models\Post;
|
|
use App\Rules\ContentTypeMatchesPostPlatform;
|
|
use Illuminate\Contracts\JsonSchema\JsonSchema;
|
|
use Illuminate\Validation\Rule;
|
|
use Laravel\Mcp\Request;
|
|
use Laravel\Mcp\Response;
|
|
use Laravel\Mcp\ResponseFactory;
|
|
use Laravel\Mcp\Server\Attributes\Description;
|
|
use Laravel\Mcp\Server\Tool;
|
|
|
|
#[Description('Update a draft post — content, media, scheduled_at, labels, and which platforms are enabled. Cannot edit a post that has already been published.')]
|
|
class UpdatePostTool extends Tool
|
|
{
|
|
public function handle(Request $request): Response|ResponseFactory
|
|
{
|
|
$workspace = $request->user()->currentWorkspace;
|
|
|
|
$postId = data_get($request->all(), 'post_id');
|
|
$post = is_string($postId) ? Post::where('workspace_id', $workspace->id)->find($postId) : null;
|
|
|
|
if (! $post) {
|
|
return Response::error('Post not found.');
|
|
}
|
|
|
|
$validated = $request->validate([
|
|
'post_id' => ['required', 'uuid'],
|
|
'content' => ['nullable', 'string', 'max:10000'],
|
|
'scheduled_at' => ['nullable', 'date', 'after:now'],
|
|
'status' => ['sometimes', 'string', Rule::in([Status::Draft->value, Status::Scheduled->value])],
|
|
'label_ids' => ['sometimes', 'array'],
|
|
'label_ids.*' => ['uuid', Rule::exists('workspace_labels', 'id')->where('workspace_id', $workspace->id)],
|
|
'platforms' => ['sometimes', 'array'],
|
|
'platforms.*.id' => [
|
|
'required',
|
|
'uuid',
|
|
Rule::exists('post_platforms', 'id')->where('post_id', $post->id),
|
|
],
|
|
'platforms.*.content_type' => ['sometimes', 'string', Rule::in(array_column(ContentType::cases(), 'value')), new ContentTypeMatchesPostPlatform],
|
|
'platforms.*.meta' => ['sometimes', 'array'],
|
|
]);
|
|
|
|
$payload = collect($validated)->except('post_id')->all();
|
|
|
|
$result = UpdatePost::execute($workspace, $post, $payload);
|
|
|
|
if (in_array(data_get($result, 'action'), [PostAction::AlreadyPublished, PostAction::Finalized], true)) {
|
|
return Response::error('Cannot edit a published post.');
|
|
}
|
|
|
|
/** @var Post $updated */
|
|
$updated = data_get($result, 'post');
|
|
$updated->load(['postPlatforms.socialAccount', 'labels']);
|
|
|
|
return Response::structured((new PostResource($updated))->resolve());
|
|
}
|
|
|
|
public function schema(JsonSchema $schema): array
|
|
{
|
|
return [
|
|
'post_id' => $schema->string()->required()->description('UUID of the post to update.'),
|
|
'content' => $schema->string()->description('New caption/text body.'),
|
|
'scheduled_at' => $schema->string()->description('ISO 8601 datetime in the future. Required if status is "scheduled".'),
|
|
'status' => $schema->string()
|
|
->enum([Status::Draft->value, Status::Scheduled->value])
|
|
->description('Post status. Use "draft" to keep editing, "scheduled" to schedule the post. Use publish-post-tool for immediate publish.'),
|
|
'label_ids' => $schema->array()
|
|
->items($schema->string())
|
|
->description('Workspace label IDs to attach (replaces existing labels).'),
|
|
'platforms' => $schema->array()
|
|
->items($schema->object(fn ($p) => [
|
|
'id' => $p->string()->required()->description('UUID of the post_platform row (from get-post-tool / list-posts-tool).'),
|
|
'content_type' => $p->string()->description('New content_type for this platform.'),
|
|
'meta' => $p->object()->description('Per-platform metadata override (e.g. aspect_ratio, board_id for Pinterest).'),
|
|
]))
|
|
->description('Platforms to enable for publishing. Any platform NOT listed will be disabled. Pass an empty array to disable all.'),
|
|
];
|
|
}
|
|
}
|