cf045f2cdb
Publishing:
- Only send alt text for images (isImage guards on LinkedIn, X, Discord, Mastodon); never inject altText into video/document payloads.
- X sets alt via a best-effort media/metadata call so a metadata failure no longer blocks the tweet.
Validation:
- Validate media alt_text with a closure on media.*.meta so width/height/duration/slide_* survive a post update (Laravel's excludeUnvalidatedArrayKeys was stripping them).
- Add ALT_TEXT_MAX_LENGTH constant, a proper string-type error, and a localized attribute name.
Media attach (REST + MCP):
- Support per-image alt on attach-media-from-url via structured urls: [{url, alt?}] and on the MCP upload tool via an optional alt; alt is stored only for images.
- Carry submitted meta onto hosted external-URL media so alt is no longer dropped.
Composer:
- Alt-text dialog disables Save and reddens the counter over the limit, counting code points of the trimmed value to match the backend.
- Autosave shows 'Saved' only on a successful response; the lightbox alt overlay renders for images only.
Adds unit, feature, MCP, and browser tests covering every path above.
136 lines
4.4 KiB
PHP
136 lines
4.4 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Enums\UserWorkspace\Role;
|
|
use App\Mcp\Servers\TryPostServer;
|
|
use App\Mcp\Tools\Post\AttachMediaFromUploadTool;
|
|
use App\Models\Media;
|
|
use App\Models\Post;
|
|
use App\Models\User;
|
|
use App\Models\Workspace;
|
|
use Illuminate\Support\Str;
|
|
|
|
beforeEach(function () {
|
|
$this->user = User::factory()->create();
|
|
$this->workspace = Workspace::factory()->create(['user_id' => $this->user->id]);
|
|
$this->workspace->members()->attach($this->user->id, ['role' => Role::Member->value]);
|
|
$this->user->update(['current_workspace_id' => $this->workspace->id]);
|
|
|
|
$this->post = Post::factory()->create([
|
|
'workspace_id' => $this->workspace->id,
|
|
'user_id' => $this->user->id,
|
|
]);
|
|
|
|
$this->token = (string) Str::uuid();
|
|
$this->media = Media::factory()->create([
|
|
'mediable_type' => (new Workspace)->getMorphClass(),
|
|
'mediable_id' => $this->workspace->id,
|
|
'collection' => 'assets',
|
|
'upload_token' => $this->token,
|
|
]);
|
|
});
|
|
|
|
test('attaches the uploaded Media to the post', function () {
|
|
$response = TryPostServer::actingAs($this->user)
|
|
->tool(AttachMediaFromUploadTool::class, [
|
|
'post_id' => $this->post->id,
|
|
'upload_token' => $this->token,
|
|
]);
|
|
|
|
$response->assertOk();
|
|
expect($this->post->fresh()->media)->toHaveCount(1);
|
|
});
|
|
|
|
test('attaches an uploaded Media with alt text stored in meta', function () {
|
|
$response = TryPostServer::actingAs($this->user)
|
|
->tool(AttachMediaFromUploadTool::class, [
|
|
'post_id' => $this->post->id,
|
|
'upload_token' => $this->token,
|
|
'alt' => 'A scenic mountain view',
|
|
]);
|
|
|
|
$response->assertOk();
|
|
expect(data_get($this->post->fresh()->media, '0.meta.alt_text'))->toBe('A scenic mountain view');
|
|
});
|
|
|
|
test('does not store alt text on a non-image upload', function () {
|
|
$video = Media::factory()->video()->create([
|
|
'mediable_type' => (new Workspace)->getMorphClass(),
|
|
'mediable_id' => $this->workspace->id,
|
|
'collection' => 'assets',
|
|
'upload_token' => (string) Str::uuid(),
|
|
]);
|
|
|
|
$response = TryPostServer::actingAs($this->user)
|
|
->tool(AttachMediaFromUploadTool::class, [
|
|
'post_id' => $this->post->id,
|
|
'upload_token' => $video->upload_token,
|
|
'alt' => 'alt is meaningless for a video',
|
|
]);
|
|
|
|
$response->assertOk();
|
|
|
|
expect(data_get($this->post->fresh()->media, '0.type'))->toBe('video')
|
|
->and(data_get($this->post->fresh()->media, '0.meta'))->toBeNull();
|
|
});
|
|
|
|
test('rejects alt text over the max length', function () {
|
|
$response = TryPostServer::actingAs($this->user)
|
|
->tool(AttachMediaFromUploadTool::class, [
|
|
'post_id' => $this->post->id,
|
|
'upload_token' => $this->token,
|
|
'alt' => str_repeat('a', 2001),
|
|
]);
|
|
|
|
$response->assertHasErrors();
|
|
});
|
|
|
|
test('rejects a token from a different workspace', function () {
|
|
$other = User::factory()->create();
|
|
$otherWs = Workspace::factory()->create(['user_id' => $other->id]);
|
|
|
|
$foreignToken = (string) Str::uuid();
|
|
Media::factory()->create([
|
|
'mediable_type' => (new Workspace)->getMorphClass(),
|
|
'mediable_id' => $otherWs->id,
|
|
'collection' => 'assets',
|
|
'upload_token' => $foreignToken,
|
|
]);
|
|
|
|
$response = TryPostServer::actingAs($this->user)
|
|
->tool(AttachMediaFromUploadTool::class, [
|
|
'post_id' => $this->post->id,
|
|
'upload_token' => $foreignToken,
|
|
]);
|
|
|
|
$response->assertHasErrors();
|
|
expect($this->post->fresh()->media)->toHaveCount(0);
|
|
});
|
|
|
|
test('rejects an unknown upload_token', function () {
|
|
$response = TryPostServer::actingAs($this->user)
|
|
->tool(AttachMediaFromUploadTool::class, [
|
|
'post_id' => $this->post->id,
|
|
'upload_token' => (string) Str::uuid(),
|
|
]);
|
|
|
|
$response->assertHasErrors();
|
|
});
|
|
|
|
test('rejects a post from another workspace', function () {
|
|
$other = User::factory()->create();
|
|
$otherWs = Workspace::factory()->create(['user_id' => $other->id]);
|
|
$otherPost = Post::factory()->create([
|
|
'workspace_id' => $otherWs->id,
|
|
'user_id' => $other->id,
|
|
]);
|
|
|
|
$response = TryPostServer::actingAs($this->user)
|
|
->tool(AttachMediaFromUploadTool::class, [
|
|
'post_id' => $otherPost->id,
|
|
'upload_token' => $this->token,
|
|
]);
|
|
|
|
$response->assertHasErrors();
|
|
});
|