4debc97cb0
Onboarding/lifecycle workflows in PostHog (and downstream tools like SendKit) need to segment users by how many social accounts they've connected and how many posts they've created. The existing SyncUser job only re-emitted these counts on signup and billing changes, so the values went stale the moment a user did anything meaningful. This wires up two new paths that refresh the account group automatically: - SocialAccountObserver (#[ObservedBy] on the model) fires SyncAccountUsage on created/deleted, covering all 14 OAuth callback paths in one hook. - SyncUsageOnPostCreated / SyncUsageOnPostDeleted listeners (auto-discovered) fire SyncAccountUsage on the corresponding events dispatched by CreatePost and DeletePost. SyncAccountUsage is the new dedicated job for group properties only (groupIdentify account + workspace). SyncUser was slimmed to just identify the user and delegate the group sync, removing the duplicated property mapping between the two jobs. All entry points (observer + both listeners) short-circuit when PostHog is disabled, so self-hosted instances without PostHog configured see zero queued jobs and zero overhead. posts_count cache is invalidated before each sync so the job reads fresh counts from the database instead of stale cached values.
132 lines
4.4 KiB
PHP
132 lines
4.4 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Jobs\PostHog\SendEvent;
|
|
use App\Jobs\PostHog\SyncAccountUsage;
|
|
use App\Models\Account;
|
|
use App\Models\Plan;
|
|
use App\Models\Post;
|
|
use App\Models\SocialAccount;
|
|
use App\Models\User;
|
|
use App\Models\Workspace;
|
|
use App\Services\PostHogService;
|
|
use Illuminate\Support\Facades\Cache;
|
|
use Illuminate\Support\Facades\Queue;
|
|
use Illuminate\Support\Str;
|
|
|
|
beforeEach(function () {
|
|
config(['services.posthog.enabled' => true, 'services.posthog.api_key' => 'phc_test_key']);
|
|
|
|
$this->account = Account::factory()->create([
|
|
'plan_id' => Plan::query()->where('slug', 'starter')->first()?->id,
|
|
]);
|
|
$this->user = User::factory()->create(['account_id' => $this->account->id]);
|
|
$this->account->update(['owner_id' => $this->user->id]);
|
|
});
|
|
|
|
test('handle is a no-op when api key is unset', function () {
|
|
config(['services.posthog.api_key' => null]);
|
|
Queue::fake();
|
|
|
|
(new SyncAccountUsage((string) $this->account->id))->handle(app(PostHogService::class));
|
|
|
|
Queue::assertNothingPushed();
|
|
});
|
|
|
|
test('handle returns silently when account does not exist', function () {
|
|
Queue::fake();
|
|
|
|
(new SyncAccountUsage((string) Str::uuid()))->handle(app(PostHogService::class));
|
|
|
|
Queue::assertNothingPushed();
|
|
});
|
|
|
|
test('handle group-identifies the account with usage metrics', function () {
|
|
$workspace = Workspace::factory()->create([
|
|
'account_id' => $this->account->id,
|
|
'user_id' => $this->user->id,
|
|
]);
|
|
SocialAccount::factory()->count(2)->create(['workspace_id' => $workspace->id]);
|
|
Post::factory()->count(3)->create([
|
|
'workspace_id' => $workspace->id,
|
|
'user_id' => $this->user->id,
|
|
]);
|
|
|
|
Queue::fake();
|
|
|
|
(new SyncAccountUsage((string) $this->account->id))->handle(app(PostHogService::class));
|
|
|
|
Queue::assertPushed(SendEvent::class, function ($job) {
|
|
if ($job->method !== 'groupIdentify' || $job->payload['groupType'] !== 'account') {
|
|
return false;
|
|
}
|
|
|
|
$props = $job->payload['properties'];
|
|
|
|
return $job->payload['groupKey'] === (string) $this->account->id
|
|
&& $props['workspaces_count'] === 1
|
|
&& $props['social_accounts_count'] === 2
|
|
&& $props['posts_count'] === 3;
|
|
});
|
|
});
|
|
|
|
test('handle group-identifies the workspace when workspaceId is provided', function () {
|
|
$workspace = Workspace::factory()->create([
|
|
'account_id' => $this->account->id,
|
|
'user_id' => $this->user->id,
|
|
]);
|
|
SocialAccount::factory()->create(['workspace_id' => $workspace->id]);
|
|
|
|
Queue::fake();
|
|
|
|
(new SyncAccountUsage((string) $this->account->id, (string) $workspace->id))->handle(app(PostHogService::class));
|
|
|
|
Queue::assertPushed(SendEvent::class, function ($job) use ($workspace) {
|
|
return $job->method === 'groupIdentify'
|
|
&& $job->payload['groupType'] === 'workspace'
|
|
&& $job->payload['groupKey'] === (string) $workspace->id
|
|
&& $job->payload['properties']['account_id'] === (string) $this->account->id
|
|
&& $job->payload['properties']['social_accounts_count'] === 1;
|
|
});
|
|
});
|
|
|
|
test('handle skips workspace group identify when workspaceId is null', function () {
|
|
Queue::fake();
|
|
|
|
(new SyncAccountUsage((string) $this->account->id))->handle(app(PostHogService::class));
|
|
|
|
Queue::assertNotPushed(SendEvent::class, function ($job) {
|
|
return $job->method === 'groupIdentify' && $job->payload['groupType'] === 'workspace';
|
|
});
|
|
});
|
|
|
|
test('handle invalidates the posts_count cache before reading usage', function () {
|
|
$workspace = Workspace::factory()->create([
|
|
'account_id' => $this->account->id,
|
|
'user_id' => $this->user->id,
|
|
]);
|
|
|
|
Cache::put("account:{$this->account->id}:posts_count", 999, 300);
|
|
|
|
Post::factory()->count(2)->create([
|
|
'workspace_id' => $workspace->id,
|
|
'user_id' => $this->user->id,
|
|
]);
|
|
|
|
Queue::fake();
|
|
|
|
(new SyncAccountUsage((string) $this->account->id))->handle(app(PostHogService::class));
|
|
|
|
Queue::assertPushed(SendEvent::class, function ($job) {
|
|
return $job->method === 'groupIdentify'
|
|
&& $job->payload['groupType'] === 'account'
|
|
&& $job->payload['properties']['posts_count'] === 2;
|
|
});
|
|
});
|
|
|
|
test('job is queued on the posthog connection queue', function () {
|
|
$job = new SyncAccountUsage((string) $this->account->id);
|
|
|
|
expect($job->queue)->toBe('posthog');
|
|
});
|