trypost/app/Services/Social/Concerns/HasSocialHttpClient.php
Paulo Castellano 6496588bbc
Defuse links in X posts to avoid the link-post fee (#308)
X bills a post containing a URL at a much higher rate than a plain post, and
its algorithm demotes link posts. The X version of a post now rewrites every
URL non-clickable (https://example.com/post becomes example(.)com/post):
scheme and www. dropped, every dot of the host replaced with (.).

Leaving a single dot intact would still leave a resolvable domain for X to
detect, so all of them are broken. A scheme or www. proves a token is a URL on
its own; a bare host only counts when its last label is a delegated TLD, which
is the one thing telling acme.com apart from Node.js. That check runs against
App\Support\LinkTlds, generated from the whole IANA root zone in every form a
TLD can appear in a post -- ASCII, punycode and the Unicode it decodes to --
because whatever X links is what X bills, so a hand-picked subset would leave
us paying for its gaps. If the regex engine bails out on pathological input the
original content is returned instead of crashing the publisher.

The transform lives in the Platform::X arm of ContentSanitizer, so it reaches
publishing and the app/API/MCP previews from one place and cannot touch any
other network. Off by default; opt in with X_DEFUSE_LINKS.

The editor counts characters and renders its preview client-side and cannot ask
the server on every keystroke, so the rewrite is mirrored in TypeScript. PHP
stays the source of truth: a parity test fails if the two TLD sets drift, and a
browser test drives the real editor so the mirror is covered rather than
assumed. Without it the composer promised text the network never receives.

Character limits now measure the text a reader will see: sanitized, then with
markup resolved away. Measuring the raw draft blocked saving posts that publish
fine and let through posts the network rejects, and counted the editor's HTML
toward the limit. Measuring the sanitized form alone would have counted
Telegram's escaped entities, rejecting messages Telegram accepts.

Empty content is handled once inside the sanitizer instead of by a guard
repeated at every call site.
2026-08-29 15:31:05 -03:00

66 lines
2.2 KiB
PHP

<?php
declare(strict_types=1);
namespace App\Services\Social\Concerns;
use App\Models\PostPlatform;
use App\Services\Social\ContentSanitizer;
use App\Services\Social\TokenRedactor;
use Exception;
use Illuminate\Http\Client\PendingRequest;
use Illuminate\Support\Facades\Http;
trait HasSocialHttpClient
{
/**
* Measures the sanitized content — the exact string the publisher sends —
* rather than the stored draft. The two differ by more than markup: X
* defusing rewrites URLs, Telegram escapes entities, and every platform
* strips HTML the editor stored. Checking the raw draft both rejected
* posts that would have fit and let through posts the network rejects.
*/
protected function validateContentLength(PostPlatform $postPlatform): void
{
$raw = $postPlatform->post->content ?? '';
$content = app(ContentSanitizer::class)->displayText($raw, $postPlatform->platform);
if ($postPlatform->platform->contentOverflow($content) === 0) {
return;
}
$maxLength = $postPlatform->platform->maxContentLength();
$contentLength = mb_strlen($content);
throw new Exception(
"Content exceeds {$postPlatform->platform->label()} limit of {$maxLength} characters ({$contentLength} provided)."
);
}
protected function socialHttp(): PendingRequest
{
return Http::retry(
times: 3,
sleepMilliseconds: 5000,
when: fn ($exception, $request) => ($exception->response ?? null)?->status() === 429,
throw: false,
)->timeout(120);
}
protected function redactResponseBody(string $body): string
{
return TokenRedactor::redact($body);
}
/**
* Reclaim memory between chunks of a streaming upload. Each request's body
* and the HTTP client's request/response objects are held alive by reference
* cycles the PHP runtime only frees when the cycle collector runs, so a
* long chunked upload accumulates the whole file in memory without this.
* Callers must `unset()` the chunk and response first.
*/
protected function freeChunkMemory(): void
{
gc_collect_cycles();
}
}