trypost/tests/Feature/Actions/Onboarding/ResolveOnboardingStatusTest.php
Paulo Castellano a1fa897106
Activation checklist + MCP OAuth authorize UX (#239) (#250)
* Wire onboarding activation into Account, observers, and shared Inertia data

Add onboarding casts/hasFinishedOnboarding, AccessToken ObservedBy,
Platform::connectableOptions, Post/SocialAccount onboarding broadcast hooks,
and lazy onboardingResidual share + SharedData types.

* Register onboarding routes and post-checkout activation redirects.

Wire billing processing and the sidebar checklist so owners land on
activation after subscribe, with locale sidebar/uk onboarding strings.

* Align MCP grant usability with onboarding activation checks

Unbound MCP tokens fall back to the user's current workspace and require
createPost so viewer/unscoped grants neither unlock the checklist nor
broadcast onboarding status.

* Require bound MCP workspace for onboarding activation.

Drop current-workspace fallback from usable MCP grants so checklist
detection and broadcasts match Passport token scoping; viewers still
cannot unlock the MCP step.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Harden onboarding review findings and tighten locale strings.

Fix Welcome/Persona/TrackPost suites broken by the activation route reuse
and PostObserver analytics side effects, restore Echo poll fallbacks,
reject unbound MCP grants in tests, and drop unused onboarding.mcp keys.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Remove unused sidebar and MCP authorization locale keys.

Drop dead sidebar menu/theme strings (including the overwritten
workspace label and api_keys nav entry) and unused MCP authorize
app_title/approving copy across all locales.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Fix SetLocale crashing on Passport Symfony OAuth responses.

OAuth errors return a raw Symfony Response without withCookie(); attach
the default locale cookie via headers so authorize no longer 500s.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Prompt OAuth guests to log in before rejecting unknown clients.

MCP Inspector often reuses a stale client_id; validateAuthorizationRequest
was returning invalid_client JSON before the login redirect. Guests now
hit /login first, then client validation runs after authentication.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Render Inertia OAuth authorize errors for browser logins.

After login, Inertia follows the intended authorize URL; raw invalid_client
JSON broke that visit. HTML/Inertia requests now get mcp/AuthorizeError
while API JSON clients still receive the OAuth error payload.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Detect Inertia OAuth error pages via Request::inertia().

Use the framework helper so post-login authorize failures keep returning
an Inertia page instead of raw OAuth JSON.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Simplify OAuth authorize error page detection to expectsJson.

Drop the X-Inertia header sniff; browser and Inertia visits already do
not expectsJson, while API clients still receive the OAuth JSON payload.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Share MCP authorize layout and drop the error close button.

Keep authorize and authorize-error on the same centered card shell instead of the auth split layout.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Simplify onboarding activation for reviewability and safety.

Use an exists-based MCP check, keep GETs read-only, move sync into
syncAndNotify, clear MCP skips on connect, restrict complete to owners,
and share Echo/poll via one composable.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Move MCP OAuth authorize UX out of the onboarding PR.

Keep the activation checklist focused; OAuth guest/error-page work now
lives on fix/mcp-oauth-authorize-ux.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Fix corrupted French MCP locale after OAuth key cleanup.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Restore MCP OAuth authorize UX onto the onboarding branch.

Keep authorize error page, guest login-before-client validation, and
SetLocale Symfony cookie fix in #250.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Fix OAuth prompt=none redirects and harden onboarding tests.

Keep login_required/consent_required as redirects instead of Inertia,
add regression coverage for owner-only activation, require invite email
confirmation, and align MCP connected apps with the sessions list UI.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Simplify onboarding guards and dedupe viewed analytics.

Introduce isOnboardingOpen / belongsToAccount helpers, collapse
duplicated sync/dispatch paths, and capture onboarding.viewed once
per account.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Simplify onboarding event, observers, and status helpers.

Tighten Account onboarding predicates, drop nullable broadcast/dispatch
APIs, and collapse repeated observer/controller guards.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Treat in-app users as always having an account.

Add resolveAccount(), tighten belongsToAccount to string ids, and fold
guest residual handling into ResolveOnboardingStatus.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Rename onboarding residual share test to progress.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Simplify onboarding status and rename residual to progress.

Use accountOrFail, extract MCP onboarding scope, auto-leave the ready
screen, and send non-onboarding checkout back to accounts.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Extract HasAccount and prefer data_get in onboarding flows.

Move account helpers off User, drop nullable sidebarProgress, and
read OAuth/onboarding payloads with data_get.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Simplify onboarding checks and extract HasOnboarding.

Use Eloquent + policies for MCP/backfill paths, and move account
onboarding helpers into a dedicated trait.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Add trait tests and tidy onboarding imports.

Cover HasAccount and HasOnboarding under Models/Traits, prefer filled() for checkout session ids, and import Throwable instead of FQCN.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Simplify checkout session_id and OAuth error props.

Read session_id via request->string(), and take OAuth error details from the League exception instead of decoding the response body.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Simplify PostObserver onboarding notify path.

Share one otherPosts check for first-create and last-delete instead of separate callbacks.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Use post author as onboarding sync actor.

Drop Auth::user() preference in PostObserver; checklist sync attributes to $post->user.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Simplify SocialAccountObserver and OAuth authorize flow.

Share create/delete onboarding notify, drop Auth actor fallback to owner, and inline Passport Inertia error handling.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Use lazy Inertia props for onboarding partial reloads.

Drop partial-header branching; wrap page props in closures and always redirect completed/dismissed accounts to the calendar.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Defer sidebar onboarding progress and stamp completion as owner-only.

Skip the MCP checklist work on full Inertia visits via deferred shared props,
early-exit token scans, and keep account completion stamps owner-gated.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Simplify deferred onboarding progress share via canShowProgress.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Add User firstName for shared auth and simplify onboarding page.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Move User firstName coverage into UserTest.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Use first_name directly without empty-name fallbacks.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Resolve onboarding sample prompt on the frontend via i18n.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Stamp onboarding completion via the account owner after teammate unlocks.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Count only the account owner MCP grant toward onboarding activation.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Fix OAuth consent auth-token mismatch for mid-activation owners.

Skip deferred onboardingProgress on Passport authorize so Inertia does not
rotate the session authToken, cover happy and stale-token paths in tests,
and polish MCP setup copy plus sidebar/onboarding layout.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Keep users on onboarding after activation completes.

Stamp completion and re-render the finished checklist instead of
redirecting to the calendar so owners can review the done state.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Clarify Passport consent-view opt-out and guard app-route deferral.

Rename the authorize-only route check and assert onboardingProgress still
defers on calendar, onboarding, and MCP settings.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Harden onboarding completion and MCP consent workspace binding.

Reject OAuth approve without a workspace, retry auto-complete until
stamped, send dismissed complete straight to calendar, and cover the
device consent defer opt-out.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Enable activation checklist for self-hosted installs.

Remove the self-hosted onboarding redirects, keep the SaaS-only dismiss backfill, and cover subscription-less owners plus skip/complete destinations.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Add GitHub, Hacker News, and directories referral sources.

Expand the welcome referral step with open-source and directory discovery channels.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Refine welcome referral sources and labels.

Split Instagram/Threads, add Founder, and shorten Google, GitHub, AI, and blog option labels.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Sort accounts platforms alphabetically and drop connect hover plus.

Reuse connectableOptions for the accounts index and remove the unused plus badge on disconnected cards.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Centralize PostHog once-capture so disabled installs don't burn dedupe keys.

Move isEnabled + Cache::add into PostHogService::captureOnce and route onboarding viewed/step events through it.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Simplify onboarding backfill to complete every existing open account.

Drop self-hosted and subscription filters; down clears completed_at again.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Drop PostHog captureOnce and use plain capture for onboarding.

Remove cache-based event dedupe; callers rely on PostHogService::capture gating.

Co-authored-by: Cursor <cursoragent@cursor.com>

---------

Co-authored-by: Cursor <cursoragent@cursor.com>
2026-08-07 20:34:43 -03:00

674 lines
26 KiB
PHP

<?php
declare(strict_types=1);
use App\Actions\Onboarding\ResolveOnboardingStatus;
use App\Enums\PostHog\OnboardingEvent;
use App\Enums\SocialAccount\Status;
use App\Enums\UserWorkspace\Role;
use App\Events\OnboardingStatusUpdated;
use App\Jobs\PostHog\SendEvent;
use App\Models\AccessToken;
use App\Models\Post;
use App\Models\SocialAccount;
use App\Models\User;
use App\Models\Workspace;
use Illuminate\Support\Carbon;
use Illuminate\Support\Facades\Bus;
use Illuminate\Support\Facades\Cache;
use Illuminate\Support\Facades\DB;
use Illuminate\Support\Facades\Event;
beforeEach(function () {
config(['trypost.self_hosted' => false]);
$this->user = User::factory()->create();
$this->workspace = Workspace::factory()->create([
'account_id' => $this->user->account_id,
'user_id' => $this->user->id,
]);
$this->user->update(['current_workspace_id' => $this->workspace->id]);
$this->user->refresh();
subscribeAccount($this->user->account);
});
test('resolves the empty onboarding state', function () {
$status = app(ResolveOnboardingStatus::class)->handle($this->user);
expect($status)->toBe([
'mcp_connected' => false,
'social_connected' => false,
'first_post_created' => false,
'skipped_steps' => [],
'all_complete' => false,
'show_progress' => true,
'completed_at' => null,
'dismissed_at' => null,
]);
});
test('resolves an OAuth token as MCP connected', function () {
mcpAccessToken($this->user, mcpOauthClient(), $this->workspace);
$status = app(ResolveOnboardingStatus::class)->handle($this->user);
expect($status)->toMatchArray([
'mcp_connected' => true,
'social_connected' => false,
'first_post_created' => false,
'all_complete' => false,
]);
});
test('does not resolve a personal access token as MCP connected', function () {
$this->user->createToken('Personal Access Token');
$status = app(ResolveOnboardingStatus::class)->handle($this->user);
expect($status['mcp_connected'])->toBeFalse();
});
test('does not resolve a workspace-bound personal access token as MCP connected', function () {
$result = $this->user->createToken('Personal Access Token');
AccessToken::find($result->token->id)
->forceFill(['workspace_id' => $this->workspace->id])
->saveQuietly();
$status = app(ResolveOnboardingStatus::class)->handle($this->user);
expect($status['mcp_connected'])->toBeFalse();
});
test('does not resolve a revoked token as MCP connected', function () {
$token = mcpAccessToken($this->user, mcpOauthClient(), $this->workspace);
$token->forceFill(['revoked' => true])->saveQuietly();
$status = app(ResolveOnboardingStatus::class)->handle($this->user);
expect($status['mcp_connected'])->toBeFalse();
});
test('resolves a social account in the current workspace as connected', function () {
SocialAccount::factory()->create(['workspace_id' => $this->workspace->id]);
$status = app(ResolveOnboardingStatus::class)->handle($this->user);
expect($status)->toMatchArray([
'mcp_connected' => false,
'social_connected' => true,
'first_post_created' => false,
'all_complete' => false,
]);
});
test('captures completed steps when progress syncs', function () {
config(['services.posthog.enabled' => true, 'services.posthog.api_key' => 'phc_test']);
Bus::fake();
SocialAccount::factory()->create(['workspace_id' => $this->workspace->id]);
app(ResolveOnboardingStatus::class)->syncProgress($this->user);
Bus::assertDispatched(SendEvent::class, fn (SendEvent $event): bool => $event->method === 'capture'
&& data_get($event->payload, 'event') === OnboardingEvent::StepCompleted->value
&& data_get($event->payload, 'properties.step') === 'social');
});
test('does not resolve an expired oauth token as mcp connected', function () {
$token = AccessToken::withoutEvents(fn () => mcpAccessToken($this->user, mcpOauthClient(), $this->workspace));
$token->forceFill(['expires_at' => now()->subMinute()])->saveQuietly();
$status = app(ResolveOnboardingStatus::class)->handle($this->user);
expect($status['mcp_connected'])->toBeFalse();
});
test('bound mcp grants count without a current workspace switcher value', function () {
$this->user->update(['current_workspace_id' => null]);
SocialAccount::withoutEvents(fn () => SocialAccount::factory()->create([
'workspace_id' => $this->workspace->id,
]));
Post::withoutEvents(fn () => Post::factory()->create([
'workspace_id' => $this->workspace->id,
'user_id' => $this->user->id,
]));
AccessToken::withoutEvents(fn () => mcpAccessToken($this->user, mcpOauthClient(), $this->workspace));
$status = app(ResolveOnboardingStatus::class)->handle($this->user->fresh());
expect($status)->toMatchArray([
'mcp_connected' => true,
'social_connected' => true,
'first_post_created' => true,
'all_complete' => true,
]);
});
test('does not resolve an unbound oauth token as mcp connected', function () {
AccessToken::withoutEvents(fn () => mcpAccessToken($this->user, mcpOauthClient()));
$status = app(ResolveOnboardingStatus::class)->handle($this->user);
expect($status['mcp_connected'])->toBeFalse()
->and($status['all_complete'])->toBeFalse();
});
test('members do not see the progress checklist', function () {
$member = User::factory()->create(['account_id' => $this->user->account_id]);
$member->update(['current_workspace_id' => $this->workspace->id]);
expect(app(ResolveOnboardingStatus::class)->sidebarProgress($member->fresh()))->toBeFalse()
->and(app(ResolveOnboardingStatus::class)->handle($member->fresh())['show_progress'])->toBeFalse();
});
test('generic trial without card still shows progress for the owner', function () {
config(['trypost.billing.require_card_for_trial' => false]);
$this->user->account->subscriptions()->delete();
$this->user->account->update(['trial_ends_at' => now()->addDays(7)]);
expect(app(ResolveOnboardingStatus::class)->sidebarProgress($this->user->fresh()))->toBe([
'completed' => 0,
'total' => ResolveOnboardingStatus::totalSteps(),
]);
});
test('resolves a social account in another workspace as connected', function () {
$otherWorkspace = Workspace::factory()->create([
'account_id' => $this->user->account_id,
'user_id' => $this->user->id,
]);
SocialAccount::factory()->create(['workspace_id' => $otherWorkspace->id]);
$status = app(ResolveOnboardingStatus::class)->handle($this->user);
expect($status['social_connected'])->toBeTrue();
});
test('does not resolve an unusable social account as connected', function (Status $status) {
SocialAccount::factory()->create([
'workspace_id' => $this->workspace->id,
'status' => $status,
]);
$onboarding = app(ResolveOnboardingStatus::class)->handle($this->user);
expect($onboarding['social_connected'])->toBeFalse();
})->with([
'disconnected' => Status::Disconnected,
'token expired' => Status::TokenExpired,
]);
test('resolves any post in the current workspace as the first post', function () {
Post::factory()->failed()->create([
'workspace_id' => $this->workspace->id,
'user_id' => $this->user->id,
]);
$status = app(ResolveOnboardingStatus::class)->handle($this->user);
expect($status)->toMatchArray([
'mcp_connected' => false,
'social_connected' => false,
'first_post_created' => true,
'all_complete' => false,
]);
});
test('resolves a post in another workspace as the first post', function () {
$otherWorkspace = Workspace::factory()->create([
'account_id' => $this->user->account_id,
'user_id' => $this->user->id,
]);
Post::factory()->create([
'workspace_id' => $otherWorkspace->id,
'user_id' => $this->user->id,
]);
$status = app(ResolveOnboardingStatus::class)->handle($this->user);
expect($status['first_post_created'])->toBeTrue();
});
test('marks onboarding completed once all three steps are complete', function () {
Carbon::setTestNow('2026-07-24 12:00:00');
mcpAccessToken($this->user, mcpOauthClient(), $this->workspace);
SocialAccount::factory()->create(['workspace_id' => $this->workspace->id]);
Post::factory()->create([
'workspace_id' => $this->workspace->id,
'user_id' => $this->user->id,
]);
$status = app(ResolveOnboardingStatus::class)->syncProgress($this->user);
expect($status)->toBe([
'mcp_connected' => true,
'social_connected' => true,
'first_post_created' => true,
'skipped_steps' => [],
'all_complete' => true,
'show_progress' => false,
'completed_at' => now()->toIso8601String(),
'dismissed_at' => null,
])->and($this->user->account->fresh()->onboarding_completed_at?->equalTo(now()))->toBeTrue();
Carbon::setTestNow(now()->addHour());
app(ResolveOnboardingStatus::class)->syncProgress($this->user->fresh());
expect($this->user->account->fresh()->onboarding_completed_at?->toIso8601String())
->toBe('2026-07-24T12:00:00+00:00');
});
test('handle does not mutate the account when every step is complete', function () {
AccessToken::withoutEvents(fn () => mcpAccessToken($this->user, mcpOauthClient(), $this->workspace));
SocialAccount::withoutEvents(fn () => SocialAccount::factory()->create([
'workspace_id' => $this->workspace->id,
]));
Post::withoutEvents(fn () => Post::factory()->create([
'workspace_id' => $this->workspace->id,
'user_id' => $this->user->id,
]));
$status = app(ResolveOnboardingStatus::class)->handle($this->user);
expect($status)->toMatchArray([
'all_complete' => true,
'show_progress' => false,
'completed_at' => null,
])->and($this->user->account->fresh()->onboarding_completed_at)->toBeNull();
});
test('stamps completion when the last step completes off the onboarding page', function () {
config(['services.posthog.enabled' => true, 'services.posthog.api_key' => 'phc_test']);
Carbon::setTestNow('2026-07-24 12:00:00');
Bus::fake();
mcpAccessToken($this->user, mcpOauthClient(), $this->workspace);
SocialAccount::factory()->create(['workspace_id' => $this->workspace->id]);
expect($this->user->account->fresh()->onboarding_completed_at)->toBeNull();
Post::factory()->create([
'workspace_id' => $this->workspace->id,
'user_id' => $this->user->id,
]);
expect($this->user->account->fresh()->onboarding_completed_at?->equalTo(now()))->toBeTrue();
Bus::assertDispatched(SendEvent::class, fn (SendEvent $event): bool => data_get($event->payload, 'event') === OnboardingEvent::Completed->value);
});
test('does not resolve a teammate oauth token as mcp connected', function () {
$member = User::factory()->create(['account_id' => $this->user->account_id]);
$this->workspace->members()->attach($member->id, ['role' => Role::Member->value]);
$member->update(['current_workspace_id' => $this->workspace->id]);
AccessToken::withoutEvents(fn () => mcpAccessToken($member, mcpOauthClient(), $this->workspace));
$status = app(ResolveOnboardingStatus::class)->handle($this->user);
expect($status['mcp_connected'])->toBeFalse();
});
test('does not resolve an unscoped oauth token as mcp connected', function () {
AccessToken::withoutEvents(
fn () => mcpAccessToken($this->user, mcpOauthClient(), $this->workspace, scopes: []),
);
$status = app(ResolveOnboardingStatus::class)->handle($this->user);
expect($status['mcp_connected'])->toBeFalse();
});
test('does not resolve a viewer oauth token as mcp connected', function () {
$viewer = User::factory()->create(['account_id' => $this->user->account_id]);
$this->workspace->members()->attach($viewer->id, ['role' => Role::Viewer->value]);
$viewer->update(['current_workspace_id' => $this->workspace->id]);
AccessToken::withoutEvents(fn () => mcpAccessToken($viewer, mcpOauthClient(), $this->workspace));
$status = app(ResolveOnboardingStatus::class)->handle($this->user);
expect($status['mcp_connected'])->toBeFalse();
});
test('dismissed onboarding does not show the progress checklist', function () {
Carbon::setTestNow('2026-07-24 12:00:00');
$this->user->account->forceFill(['onboarding_dismissed_at' => now()])->save();
$status = app(ResolveOnboardingStatus::class)->handle($this->user->fresh());
expect($status['show_progress'])->toBeFalse()
->and($status['dismissed_at'])->toBe(now()->toIso8601String());
});
test('completed onboarding returns immediately without resolving steps or capturing analytics', function () {
config(['services.posthog.enabled' => true, 'services.posthog.api_key' => 'phc_test']);
Carbon::setTestNow('2026-07-24 12:00:00');
Bus::fake();
$this->user->account->forceFill(['onboarding_completed_at' => now()])->save();
$status = app(ResolveOnboardingStatus::class)->syncProgress($this->user->fresh());
expect($status)->toBe([
'mcp_connected' => true,
'social_connected' => true,
'first_post_created' => true,
'skipped_steps' => [],
'all_complete' => true,
'show_progress' => false,
'completed_at' => now()->toIso8601String(),
'dismissed_at' => null,
]);
Bus::assertNothingDispatched();
});
test('self-hosted onboarding shows the progress checklist for owners', function () {
config(['trypost.self_hosted' => true]);
$status = app(ResolveOnboardingStatus::class)->handle($this->user);
expect($status['show_progress'])->toBeTrue();
});
test('unsubscribed account does not show the progress checklist', function () {
$this->user->account->subscriptions()->delete();
$status = app(ResolveOnboardingStatus::class)->handle($this->user);
expect($status['show_progress'])->toBeFalse();
});
test('sidebar progress returns progress counts while onboarding is active', function () {
SocialAccount::factory()->create([
'workspace_id' => $this->workspace->id,
]);
expect(app(ResolveOnboardingStatus::class)->sidebarProgress($this->user))->toBe([
'completed' => 1,
'total' => ResolveOnboardingStatus::totalSteps(),
]);
});
test('checklist and sidebar progress both count social and posts from any workspace', function () {
AccessToken::withoutEvents(fn () => mcpAccessToken($this->user, mcpOauthClient(), $this->workspace));
$otherWorkspace = Workspace::factory()->create([
'account_id' => $this->user->account_id,
'user_id' => $this->user->id,
]);
SocialAccount::withoutEvents(fn () => SocialAccount::factory()->create([
'workspace_id' => $otherWorkspace->id,
]));
$emptyWorkspace = Workspace::factory()->create([
'account_id' => $this->user->account_id,
'user_id' => $this->user->id,
]);
$this->user->update(['current_workspace_id' => $emptyWorkspace->id]);
expect(app(ResolveOnboardingStatus::class)->handle($this->user->fresh()))->toMatchArray([
'mcp_connected' => true,
'social_connected' => true,
'first_post_created' => false,
'all_complete' => false,
'show_progress' => true,
])->and(app(ResolveOnboardingStatus::class)->sidebarProgress($this->user->fresh()))->toBe([
'completed' => 2,
'total' => ResolveOnboardingStatus::totalSteps(),
]);
});
test('sidebar progress returns false when the banner should not show', function () {
$this->user->account->forceFill(['onboarding_dismissed_at' => now()])->save();
expect(app(ResolveOnboardingStatus::class)->sidebarProgress($this->user->fresh()))->toBeFalse();
});
test('syncProgress stamps via the owner when a teammate unlocks the last step', function () {
Carbon::setTestNow('2026-07-24 12:00:00');
AccessToken::withoutEvents(fn () => mcpAccessToken($this->user, mcpOauthClient(), $this->workspace));
SocialAccount::withoutEvents(fn () => SocialAccount::factory()->create([
'workspace_id' => $this->workspace->id,
]));
$member = User::factory()->create(['account_id' => $this->user->account_id]);
$this->workspace->members()->attach($member->id, ['role' => Role::Member->value]);
$member->update(['current_workspace_id' => $this->workspace->id]);
expect(app(ResolveOnboardingStatus::class)->syncProgress($member->fresh())['all_complete'])->toBeFalse();
Post::withoutEvents(fn () => Post::factory()->create([
'workspace_id' => $this->workspace->id,
'user_id' => $member->id,
]));
expect(app(ResolveOnboardingStatus::class)->syncProgress($member->fresh())['all_complete'])->toBeTrue()
->and($this->user->account->fresh()->onboarding_completed_at?->equalTo(now()))->toBeTrue();
});
test('markCompleted refuses teammates', function () {
$member = User::factory()->create(['account_id' => $this->user->account_id]);
$this->workspace->members()->attach($member->id, ['role' => Role::Member->value]);
expect(app(ResolveOnboardingStatus::class)->markCompleted($member->fresh()))->toBeFalse()
->and($this->user->account->fresh()->onboarding_completed_at)->toBeNull();
});
test('teammate mcp connection does not complete the mcp onboarding step', function () {
config(['services.posthog.enabled' => true, 'services.posthog.api_key' => 'phc_test']);
Bus::fake();
Cache::flush();
$member = User::factory()->create([
'account_id' => $this->user->account_id,
'current_workspace_id' => $this->workspace->id,
]);
$this->workspace->members()->attach($member->id, ['role' => Role::Member->value]);
mcpAccessToken($member, mcpOauthClient(), $this->workspace);
expect(app(ResolveOnboardingStatus::class)->handle($this->user->fresh())['mcp_connected'])->toBeFalse();
Bus::assertNotDispatched(
SendEvent::class,
fn (SendEvent $event): bool => $event->method === 'capture'
&& data_get($event->payload, 'event') === OnboardingEvent::StepCompleted->value
&& data_get($event->payload, 'properties.step') === 'mcp',
);
});
test('markCompleted leaves the in-memory account clean', function () {
Carbon::setTestNow('2026-07-24 12:00:00');
Event::fake([OnboardingStatusUpdated::class]);
expect(app(ResolveOnboardingStatus::class)->markCompleted($this->user))->toBeTrue()
->and($this->user->account->isDirty())->toBeFalse()
->and($this->user->account->onboarding_completed_at?->equalTo(now()))->toBeTrue();
Event::assertDispatched(
OnboardingStatusUpdated::class,
fn (OnboardingStatusUpdated $event): bool => $event->workspaceId === $this->workspace->id,
);
});
test('markCompleted refuses to stamp after onboarding was dismissed', function () {
$this->user->account->forceFill(['onboarding_dismissed_at' => now()])->save();
expect(app(ResolveOnboardingStatus::class)->markCompleted($this->user->fresh()))->toBeFalse()
->and($this->user->account->fresh()->onboarding_completed_at)->toBeNull();
});
test('syncProgress stamps when another workspace already finished social and post', function () {
Carbon::setTestNow('2026-07-29 12:00:00');
SocialAccount::withoutEvents(fn () => SocialAccount::factory()->create([
'workspace_id' => $this->workspace->id,
]));
Post::withoutEvents(fn () => Post::factory()->create([
'workspace_id' => $this->workspace->id,
'user_id' => $this->user->id,
]));
AccessToken::withoutEvents(fn () => mcpAccessToken($this->user, mcpOauthClient(), $this->workspace));
$emptyWorkspace = Workspace::factory()->create([
'account_id' => $this->user->account_id,
'user_id' => $this->user->id,
]);
$this->user->update(['current_workspace_id' => $emptyWorkspace->id]);
$status = app(ResolveOnboardingStatus::class)->syncProgress($this->user->fresh());
expect($status['all_complete'])->toBeTrue()
->and($status['show_progress'])->toBeFalse()
->and($this->user->account->fresh()->onboarding_completed_at?->equalTo(now()))->toBeTrue();
});
test('sidebar progress hides without writing when another workspace already finished activation', function () {
SocialAccount::withoutEvents(fn () => SocialAccount::factory()->create([
'workspace_id' => $this->workspace->id,
]));
Post::withoutEvents(fn () => Post::factory()->create([
'workspace_id' => $this->workspace->id,
'user_id' => $this->user->id,
]));
AccessToken::withoutEvents(fn () => mcpAccessToken($this->user, mcpOauthClient(), $this->workspace));
$emptyWorkspace = Workspace::factory()->create([
'account_id' => $this->user->account_id,
'user_id' => $this->user->id,
]);
$this->user->update(['current_workspace_id' => $emptyWorkspace->id]);
expect(app(ResolveOnboardingStatus::class)->sidebarProgress($this->user->fresh()))->toBeFalse()
->and($this->user->account->fresh()->onboarding_completed_at)->toBeNull();
});
test('sidebar progress does not query step state for dismissed accounts', function () {
$this->user->account->forceFill(['onboarding_dismissed_at' => now()])->save();
$queries = [];
DB::listen(fn ($query) => $queries[] = $query->sql);
expect(app(ResolveOnboardingStatus::class)->sidebarProgress($this->user->fresh()))->toBeFalse();
expect(collect($queries)->filter(fn (string $sql): bool => str_contains($sql, 'oauth_access_tokens')
|| str_contains($sql, 'social_accounts')
|| str_contains($sql, 'posts')))->toBeEmpty();
});
test('sidebar progress does not query step state for members', function () {
$member = User::factory()->create(['account_id' => $this->user->account_id]);
$member->update(['current_workspace_id' => $this->workspace->id]);
$queries = [];
DB::listen(fn ($query) => $queries[] = $query->sql);
expect(app(ResolveOnboardingStatus::class)->sidebarProgress($member->fresh()))->toBeFalse();
expect(collect($queries)->filter(fn (string $sql): bool => str_contains($sql, 'oauth_access_tokens')
|| str_contains($sql, 'social_accounts')
|| str_contains($sql, 'posts')))->toBeEmpty();
});
test('sidebar progress works in self hosted mode', function () {
config(['trypost.self_hosted' => true]);
SocialAccount::factory()->create([
'workspace_id' => $this->workspace->id,
]);
expect(app(ResolveOnboardingStatus::class)->sidebarProgress($this->user->fresh()))->toBe([
'completed' => 1,
'total' => ResolveOnboardingStatus::totalSteps(),
]);
});
test('skipMcp marks the optional MCP step as skipped without completing the checklist', function () {
Carbon::setTestNow('2026-07-24 12:00:00');
expect(app(ResolveOnboardingStatus::class)->skipMcp($this->user))->toBeTrue();
$status = app(ResolveOnboardingStatus::class)->handle($this->user->fresh());
expect($status['skipped_steps'])->toBe(['mcp'])
->and($status['mcp_connected'])->toBeFalse()
->and($status['all_complete'])->toBeFalse()
->and($this->user->account->fresh()->onboarding_completed_at)->toBeNull();
});
test('skipMcp completes the checklist when MCP was the last open step', function () {
Carbon::setTestNow('2026-07-24 12:00:00');
SocialAccount::withoutEvents(fn () => SocialAccount::factory()->create([
'workspace_id' => $this->workspace->id,
]));
Post::withoutEvents(fn () => Post::factory()->create([
'workspace_id' => $this->workspace->id,
'user_id' => $this->user->id,
]));
expect(app(ResolveOnboardingStatus::class)->skipMcp($this->user))->toBeTrue();
expect($this->user->account->fresh()->onboarding_completed_at?->equalTo(now()))->toBeTrue();
// Ready UI must keep the Skipped badge — do not force mcp_connected=true.
$status = app(ResolveOnboardingStatus::class)->handle($this->user->fresh());
expect($status['mcp_connected'])->toBeFalse()
->and($status['skipped_steps'])->toBe(['mcp'])
->and($status['all_complete'])->toBeTrue();
});
test('skipMcp refuses when MCP is already connected or already skipped', function () {
mcpAccessToken($this->user, mcpOauthClient(), $this->workspace);
expect(app(ResolveOnboardingStatus::class)->skipMcp($this->user->fresh()))->toBeFalse();
expect($this->user->account->fresh()->onboarding_skipped_steps)->toBeNull();
});
test('sidebar progress counts a skipped step as done', function () {
SocialAccount::withoutEvents(fn () => SocialAccount::factory()->create([
'workspace_id' => $this->workspace->id,
]));
app(ResolveOnboardingStatus::class)->skipMcp($this->user);
expect(app(ResolveOnboardingStatus::class)->sidebarProgress($this->user->fresh()))->toBe([
'completed' => 2,
'total' => ResolveOnboardingStatus::totalSteps(),
]);
});
test('connecting the mcp step after skipping it clears the skip on sync', function () {
app(ResolveOnboardingStatus::class)->skipMcp($this->user);
mcpAccessToken($this->user, mcpOauthClient(), $this->workspace);
$status = app(ResolveOnboardingStatus::class)->syncProgress($this->user->fresh());
expect($status['mcp_connected'])->toBeTrue()
->and($status['skipped_steps'])->toBe([])
->and($this->user->account->fresh()->onboarding_skipped_steps)->toBeNull();
});
test('connecting mcp after a skipped step completed onboarding replaces the skipped status', function () {
SocialAccount::withoutEvents(fn () => SocialAccount::factory()->create([
'workspace_id' => $this->workspace->id,
]));
Post::withoutEvents(fn () => Post::factory()->create([
'workspace_id' => $this->workspace->id,
'user_id' => $this->user->id,
]));
expect(app(ResolveOnboardingStatus::class)->skipMcp($this->user))->toBeTrue()
->and($this->user->account->fresh()->onboarding_completed_at)->not->toBeNull();
mcpAccessToken($this->user, mcpOauthClient(), $this->workspace);
$status = app(ResolveOnboardingStatus::class)->handle($this->user->fresh());
expect($status['mcp_connected'])->toBeTrue()
->and($status['skipped_steps'])->toBe([]);
});