trypost/tests/Feature/Api/LoadWorkspaceFromTokenTest.php
Paulo Castellano 4d8353d758
MCP: workspace settings, viewer read access, and token access (#241)
* Add workspace MCP settings and token access controls.

Ship MCP settings UI, OAuth revoke/list helpers, Passport deploy wiring,
and workspace.token:mcp gating so assistants can connect without pulling
in welcome/onboarding from the parent epic.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Type MCP client config shapes instead of string checks.

Encode http/config-root on each advanced client and tighten primary
client ids so snippet generation does not branch on magic strings.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Polish MCP settings follow-ups from review.

Translate Ukrainian MCP copy, deep-link ChatGPT into connector
creation, drop an unused asset and revoke arg, and assert PATs are
rejected on the MCP endpoint.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Harden MCP connected clients, revoke scope, and OAuth consent.

List recoverable sessions with live refresh tokens, revoke only PATs,
throttle registration alone, and block viewers from authorizing MCP.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Simplify MCP OAuth route throttling to a single middleware group.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Allow workspace viewers read-only MCP access with web policy writes.

Mirror the web app: MCP connects on view + OAuth mcp:use, write tools
enforce createPost/update/delete/manageAccounts/manageTeam, and demotion
to Viewer keeps grants. Cover role denials, consent, and disconnect.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Harden MCP tool authz with shared workspace helpers.

Route ApiKey tools through AuthorizesMcpTool, fail closed on null user
or policy argument, and resolve the current workspace before mutating.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Drop redundant string casts on validated request data.

Enum::from and validated() fields are already strings, so the casts
add noise without changing behavior.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Show only the current user's MCP connections in settings.

Match API keys privacy: list and disconnect your own OAuth clients,
not teammates' across the account.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Cover LoadWorkspaceFromToken gaps and harden AuthorizesMcpTool tests.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Drop redundant is_string guard before UpdatePostTool find.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Refactor AppSidebar to always show MCP link and simplify route middleware definition in ai.php. The MCP link is now consistently displayed regardless of the current workspace state, and the route middleware syntax has been streamlined.

* Refresh MCP connected clients with Inertia usePoll.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Bump laravel/mcp to 0.9.1 and add the TryPost server icon.

Requires laravel/boost 2.5 for the Icon attribute; expose images/trypost/icon.png on TryPostServer.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Drop no-op ReflectionClass import in TryPostServerTest.

Co-authored-by: Cursor <cursoragent@cursor.com>

---------

Co-authored-by: Cursor <cursoragent@cursor.com>
2026-08-06 09:54:51 -03:00

445 lines
17 KiB
PHP

<?php
declare(strict_types=1);
use App\Enums\UserWorkspace\Role;
use App\Models\AccessToken;
use App\Models\Account;
use App\Models\User;
use App\Models\Workspace;
use Illuminate\Support\Facades\DB;
use Symfony\Component\HttpFoundation\Response;
beforeEach(function () {
config([
'trypost.self_hosted' => false,
'trypost.billing.require_card_for_trial' => true,
]);
$result = createApiTestToken();
$this->user = $result['user'];
$this->workspace = $result['workspace'];
$this->plainToken = $result['plain_token'];
});
test('rejects api requests when the account has no app access', function () {
$this->withHeaders(['Authorization' => 'Bearer '.$this->plainToken])
->getJson(route('api.workspace.show'))
->assertStatus(Response::HTTP_PAYMENT_REQUIRED)
->assertJson(['message' => 'Active subscription required.']);
});
test('allows api requests for subscribed accounts', function () {
subscribeAccount($this->user->account);
$this->withHeaders(['Authorization' => 'Bearer '.$this->plainToken])
->getJson(route('api.workspace.show'))
->assertOk();
});
test('rejects a personal access token after its stored expiration', function () {
subscribeAccount($this->user->account);
AccessToken::query()
->where('user_id', $this->user->id)
->where('workspace_id', $this->workspace->id)
->firstOrFail()
->forceFill(['expires_at' => now()->subMinute()])
->saveQuietly();
$this->withHeaders(['Authorization' => 'Bearer '.$this->plainToken])
->getJson(route('api.workspace.show'))
->assertUnauthorized()
->assertJson(['message' => 'Token expired.']);
});
test('allows api requests for generic-trial accounts with app access', function () {
config(['trypost.billing.require_card_for_trial' => false]);
$this->user->account->update([
'trial_ends_at' => now()->addDays(8),
]);
expect($this->user->account->fresh()->hasAppAccess())->toBeTrue()
->and($this->user->account->fresh()->subscribed(Account::SUBSCRIPTION_NAME))->toBeFalse();
$this->withHeaders(['Authorization' => 'Bearer '.$this->plainToken])
->getJson(route('api.workspace.show'))
->assertOk();
});
test('allows personal access tokens without a subscription in self-hosted mode', function () {
config(['trypost.self_hosted' => true]);
expect($this->user->account->subscribed(Account::SUBSCRIPTION_NAME))->toBeFalse();
$this->withHeaders(['Authorization' => 'Bearer '.$this->plainToken])
->getJson(route('api.workspace.show'))
->assertOk();
});
test('allows scoped mcp oauth without a subscription in self-hosted mode', function () {
config(['trypost.self_hosted' => true]);
$result = $this->user->createToken('MCP', ['mcp:use']);
$token = AccessToken::query()->findOrFail($result->token->id);
DB::table('oauth_clients')
->where('id', $token->client_id)
->update(['grant_types' => json_encode(['authorization_code'])]);
$this->withHeaders([
'Authorization' => "Bearer {$result->accessToken}",
'Accept' => 'application/json, text/event-stream',
])->postJson(route('mcp.trypost'), [
'jsonrpc' => '2.0',
'id' => 1,
'method' => 'initialize',
'params' => [
'protocolVersion' => '2025-03-26',
'capabilities' => (object) [],
'clientInfo' => ['name' => 'Pest', 'version' => '1.0'],
],
])->assertSuccessful();
});
test('rejects a personal token after its owner is demoted from admin', function () {
subscribeAccount($this->user->account);
$admin = User::factory()->create(['account_id' => $this->user->account_id]);
$this->workspace->members()->attach($admin->id, ['role' => Role::Admin->value]);
$admin->update(['current_workspace_id' => $this->workspace->id]);
$plainToken = passportToken($admin, $this->workspace);
$this->workspace->members()->updateExistingPivot($admin->id, [
'role' => Role::Viewer->value,
]);
$this->withHeaders(['Authorization' => "Bearer {$plainToken}"])
->getJson(route('api.workspace.show'))
->assertForbidden()
->assertJson(['message' => 'Insufficient workspace permissions.']);
});
test('rejects a personal token after its owner is removed from the workspace', function () {
subscribeAccount($this->user->account);
$admin = User::factory()->create(['account_id' => $this->user->account_id]);
$this->workspace->members()->attach($admin->id, ['role' => Role::Admin->value]);
$admin->update(['current_workspace_id' => $this->workspace->id]);
$plainToken = passportToken($admin, $this->workspace);
$this->workspace->members()->detach($admin->id);
$this->withHeaders(['Authorization' => "Bearer {$plainToken}"])
->getJson(route('api.workspace.show'))
->assertForbidden()
->assertJson(['message' => 'Workspace access denied.']);
});
test('rejects mcp oauth grants on api routes for workspace viewers', function () {
subscribeAccount($this->user->account);
$viewer = User::factory()->create(['account_id' => $this->user->account_id]);
$this->workspace->members()->attach($viewer->id, ['role' => Role::Viewer->value]);
$viewer->update(['current_workspace_id' => $this->workspace->id]);
$result = $viewer->createToken('MCP', ['mcp:use']);
$token = AccessToken::query()->findOrFail($result->token->id);
DB::table('oauth_clients')
->where('id', $token->client_id)
->update(['grant_types' => json_encode(['authorization_code'])]);
$this->withHeaders(['Authorization' => "Bearer {$result->accessToken}"])
->getJson(route('api.workspace.show'))
->assertForbidden()
->assertJson(['message' => 'Personal access token required.']);
});
test('rejects scoped mcp oauth grants on api routes', function () {
subscribeAccount($this->user->account);
$member = User::factory()->create(['account_id' => $this->user->account_id]);
$this->workspace->members()->attach($member->id, ['role' => Role::Member->value]);
$member->update(['current_workspace_id' => $this->workspace->id]);
$result = $member->createToken('MCP', ['mcp:use']);
$token = AccessToken::query()->findOrFail($result->token->id);
DB::table('oauth_clients')
->where('id', $token->client_id)
->update(['grant_types' => json_encode(['authorization_code'])]);
$this->withHeaders(['Authorization' => "Bearer {$result->accessToken}"])
->getJson(route('api.workspace.show'))
->assertForbidden()
->assertJson(['message' => 'Personal access token required.']);
});
test('rejects unscoped mcp oauth grants on api routes', function () {
subscribeAccount($this->user->account);
$member = User::factory()->create(['account_id' => $this->user->account_id]);
$this->workspace->members()->attach($member->id, ['role' => Role::Member->value]);
$member->update(['current_workspace_id' => $this->workspace->id]);
$result = $member->createToken('MCP');
$token = AccessToken::query()->findOrFail($result->token->id);
DB::table('oauth_clients')
->where('id', $token->client_id)
->update(['grant_types' => json_encode(['authorization_code'])]);
$this->withHeaders(['Authorization' => "Bearer {$result->accessToken}"])
->getJson(route('api.workspace.show'))
->assertForbidden()
->assertJson(['message' => 'Personal access token required.']);
});
test('rejects personal access tokens on the mcp endpoint', function () {
subscribeAccount($this->user->account);
$this->withHeaders([
'Authorization' => 'Bearer '.$this->plainToken,
'Accept' => 'application/json, text/event-stream',
])->postJson(route('mcp.trypost'), [
'jsonrpc' => '2.0',
'id' => 1,
'method' => 'initialize',
'params' => [
'protocolVersion' => '2025-03-26',
'capabilities' => (object) [],
'clientInfo' => ['name' => 'Pest', 'version' => '1.0'],
],
])
->assertForbidden()
->assertJson(['message' => 'MCP OAuth authorization required.']);
});
test('rejects oauth grants without the mcp scope on the mcp endpoint', function () {
subscribeAccount($this->user->account);
$member = User::factory()->create(['account_id' => $this->user->account_id]);
$this->workspace->members()->attach($member->id, ['role' => Role::Member->value]);
$member->update(['current_workspace_id' => $this->workspace->id]);
$result = $member->createToken('MCP');
$token = AccessToken::query()->findOrFail($result->token->id);
DB::table('oauth_clients')
->where('id', $token->client_id)
->update(['grant_types' => json_encode(['authorization_code'])]);
$this->withHeaders([
'Authorization' => "Bearer {$result->accessToken}",
'Accept' => 'application/json, text/event-stream',
])->postJson(route('mcp.trypost'), [
'jsonrpc' => '2.0',
'id' => 1,
'method' => 'initialize',
'params' => [
'protocolVersion' => '2025-03-26',
'capabilities' => (object) [],
'clientInfo' => ['name' => 'Pest', 'version' => '1.0'],
],
])->assertForbidden();
});
test('allows scoped oauth grants for workspace members on the mcp endpoint', function () {
subscribeAccount($this->user->account);
$member = User::factory()->create(['account_id' => $this->user->account_id]);
$this->workspace->members()->attach($member->id, ['role' => Role::Member->value]);
$member->update(['current_workspace_id' => $this->workspace->id]);
$result = $member->createToken('MCP', ['mcp:use']);
$token = AccessToken::query()->findOrFail($result->token->id);
DB::table('oauth_clients')
->where('id', $token->client_id)
->update(['grant_types' => json_encode(['authorization_code'])]);
$this->withHeaders([
'Authorization' => "Bearer {$result->accessToken}",
'Accept' => 'application/json, text/event-stream',
])->postJson(route('mcp.trypost'), [
'jsonrpc' => '2.0',
'id' => 1,
'method' => 'initialize',
'params' => [
'protocolVersion' => '2025-03-26',
'capabilities' => (object) [],
'clientInfo' => ['name' => 'Pest', 'version' => '1.0'],
],
])->assertSuccessful();
});
test('allows scoped oauth grants for workspace viewers on the mcp endpoint', function () {
subscribeAccount($this->user->account);
$viewer = User::factory()->create(['account_id' => $this->user->account_id]);
$this->workspace->members()->attach($viewer->id, ['role' => Role::Viewer->value]);
$viewer->update(['current_workspace_id' => $this->workspace->id]);
$result = $viewer->createToken('MCP', ['mcp:use']);
$token = AccessToken::query()->findOrFail($result->token->id);
DB::table('oauth_clients')
->where('id', $token->client_id)
->update(['grant_types' => json_encode(['authorization_code'])]);
$this->withHeaders([
'Authorization' => "Bearer {$result->accessToken}",
'Accept' => 'application/json, text/event-stream',
])->postJson(route('mcp.trypost'), [
'jsonrpc' => '2.0',
'id' => 1,
'method' => 'initialize',
'params' => [
'protocolVersion' => '2025-03-26',
'capabilities' => (object) [],
'clientInfo' => ['name' => 'Pest', 'version' => '1.0'],
],
])->assertSuccessful();
});
test('rejects a revoked personal access token on api routes', function () {
subscribeAccount($this->user->account);
AccessToken::query()
->where('user_id', $this->user->id)
->where('workspace_id', $this->workspace->id)
->firstOrFail()
->forceFill(['revoked' => true])
->saveQuietly();
$this->withHeaders(['Authorization' => 'Bearer '.$this->plainToken])
->getJson(route('api.workspace.show'))
->assertUnauthorized();
});
test('does not treat oauth tokens with a revoked client as personal access tokens', function () {
$result = $this->user->createToken('MCP', ['mcp:use']);
$token = AccessToken::query()->findOrFail($result->token->id);
DB::table('oauth_clients')
->where('id', $token->client_id)
->update([
'grant_types' => json_encode(['authorization_code']),
'revoked' => true,
]);
$token = $token->fresh();
expect($token->isPersonalAccessToken())->toBeFalse()
->and($token->isActiveMcpGrant())->toBeFalse();
});
test('rejects api requests without a bearer token', function () {
$this->getJson(route('api.workspace.show'))
->assertUnauthorized();
});
test('rejects mcp oauth when no current workspace is selected', function () {
subscribeAccount($this->user->account);
$result = $this->user->createToken('MCP', ['mcp:use']);
$token = AccessToken::query()->findOrFail($result->token->id);
DB::table('oauth_clients')
->where('id', $token->client_id)
->update(['grant_types' => json_encode(['authorization_code'])]);
$this->user->update(['current_workspace_id' => null]);
$this->withHeaders([
'Authorization' => "Bearer {$result->accessToken}",
'Accept' => 'application/json, text/event-stream',
])->postJson(route('mcp.trypost'), [
'jsonrpc' => '2.0',
'id' => 1,
'method' => 'initialize',
'params' => [
'protocolVersion' => '2025-03-26',
'capabilities' => (object) [],
'clientInfo' => ['name' => 'Pest', 'version' => '1.0'],
],
])
->assertUnauthorized()
->assertJson(['message' => 'No workspace selected.']);
});
test('allows mcp oauth that follows the users current workspace', function () {
subscribeAccount($this->user->account);
$otherWorkspace = Workspace::factory()->create([
'account_id' => $this->user->account_id,
'user_id' => $this->user->id,
]);
$otherWorkspace->members()->attach($this->user->id, ['role' => Role::Member->value]);
$result = $this->user->createToken('MCP', ['mcp:use']);
$token = AccessToken::query()->findOrFail($result->token->id);
DB::table('oauth_clients')
->where('id', $token->client_id)
->update(['grant_types' => json_encode(['authorization_code'])]);
$payload = [
'jsonrpc' => '2.0',
'id' => 1,
'method' => 'initialize',
'params' => [
'protocolVersion' => '2025-03-26',
'capabilities' => (object) [],
'clientInfo' => ['name' => 'Pest', 'version' => '1.0'],
],
];
$this->user->update(['current_workspace_id' => $otherWorkspace->id]);
$this->withHeaders([
'Authorization' => "Bearer {$result->accessToken}",
'Accept' => 'application/json, text/event-stream',
])->postJson(route('mcp.trypost'), $payload)->assertSuccessful();
$this->user->update(['current_workspace_id' => $this->workspace->id]);
$this->withHeaders([
'Authorization' => "Bearer {$result->accessToken}",
'Accept' => 'application/json, text/event-stream',
])->postJson(route('mcp.trypost'), $payload)->assertSuccessful();
});
test('records last_used_at on the access token after a successful api request', function () {
subscribeAccount($this->user->account);
$token = AccessToken::query()
->where('user_id', $this->user->id)
->where('workspace_id', $this->workspace->id)
->firstOrFail();
expect($token->last_used_at)->toBeNull();
$this->withHeaders(['Authorization' => 'Bearer '.$this->plainToken])
->getJson(route('api.workspace.show'))
->assertOk();
expect($token->fresh()->last_used_at)->not->toBeNull();
});
test('rejects an expired mcp oauth grant on the mcp endpoint', function () {
subscribeAccount($this->user->account);
$result = $this->user->createToken('MCP', ['mcp:use']);
$token = AccessToken::query()->findOrFail($result->token->id);
DB::table('oauth_clients')
->where('id', $token->client_id)
->update(['grant_types' => json_encode(['authorization_code'])]);
$token->forceFill(['expires_at' => now()->subMinute()])->saveQuietly();
$this->withHeaders([
'Authorization' => "Bearer {$result->accessToken}",
'Accept' => 'application/json, text/event-stream',
])->postJson(route('mcp.trypost'), [
'jsonrpc' => '2.0',
'id' => 1,
'method' => 'initialize',
'params' => [
'protocolVersion' => '2025-03-26',
'capabilities' => (object) [],
'clientInfo' => ['name' => 'Pest', 'version' => '1.0'],
],
])
->assertUnauthorized()
->assertJson(['message' => 'Token expired.']);
});